From owner-svn-src-head@freebsd.org Tue Apr 25 22:00:52 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 902D5D330EE; Tue, 25 Apr 2017 22:00:52 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-qt0-x230.google.com (mail-qt0-x230.google.com [IPv6:2607:f8b0:400d:c0d::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C523194C; Tue, 25 Apr 2017 22:00:52 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-qt0-x230.google.com with SMTP id y33so152200842qta.2; Tue, 25 Apr 2017 15:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ShtlmhKTMM4tIwIfNHygiLcpW/hVJxt3h3Z02KJ6MR4=; b=MF3sEjIM7AtoYf4Ruo6u729XRMRq20LMPp3rqTNNFR8vEhDy/bAN6WczEo1WIt94L9 jdHCuHGqQDsxYkcqpOKy4C672DBhBpC/T353jYOMcSWLMQ1RqVLILZ6j4oK/tFWCrhBy 7Mh28IjhSsDiuiyd0bvlRtyJS1VEFRTMewgEfMQXeTzahFoVvn6dHPUrWBGNdcmOakij APGlgF34R4PMawxsVyWi4mdukBU65GZsTdzhuk6YHqT4UDVbXjYBbcY53KHL+C1Q+5MN ZAwp+fV7TfYosXW9Ld0gMlEDzxCZgfJY86PND2mKBAyLRmikon9R2AYCYWgqjrbSsx58 WViw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ShtlmhKTMM4tIwIfNHygiLcpW/hVJxt3h3Z02KJ6MR4=; b=Y5B2popuf3xjGDvW/Ty7dWL6UM4z90Jnmz1OiIh6XxADi+Ma+RsQ0IQJ28TFA8tSal iL8cw1+xtF/KR1k1uCcPkd2kRvTpf4+NiIqpzxGOULryg7kkIDbHZsFLBMTtq4MrcGHR hGnPePROUYEmJxOv9NSPbgNhU6KijbQnwf5RoEeS9wtgRHn5scDmf2lchFj2hGWZFKTA R/InliHdQWsaxtEVIpt7NFpTMuVUvvkwam5eXAyCTkj3TskGxPjYDKO7xHzW0xuyx6Xp e8OXYKMStFC/XSSENb+orCU9Ihl/Q/pKD/JXnqeDAmHgLc+ABQXniB3JYIfiTCkAjsm4 SQbQ== X-Gm-Message-State: AN3rC/7/wSW6OGTEvXr+ZYx4P46qX1b6GspNgLVA+TjzzvpqAYQjev/G 36G6K4JpajOtpGerSenC+XeqLDX7otaX X-Received: by 10.200.48.168 with SMTP id v37mr35150733qta.84.1493157650497; Tue, 25 Apr 2017 15:00:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.93.83 with HTTP; Tue, 25 Apr 2017 15:00:50 -0700 (PDT) In-Reply-To: References: <201704251807.v3PI7mPL007042@repo.freebsd.org> From: Ngie Cooper Date: Tue, 25 Apr 2017 15:00:50 -0700 Message-ID: Subject: Re: svn commit: r317415 - in head: lib/libbsnmp/libbsnmp tools/build/mk To: Glen Barber Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2017 22:00:52 -0000 On Tue, Apr 25, 2017 at 3:00 PM, Ngie Cooper wrote: > On Tue, Apr 25, 2017 at 11:07 AM, Glen Barber wrote: >> Author: gjb >> Date: Tue Apr 25 18:07:48 2017 >> New Revision: 317415 >> URL: https://svnweb.freebsd.org/changeset/base/317415 >> >> Log: >> Remove an incorrect MLINK for tree(3) introduced in r310728. >> >> Reported by: many >> PR: 216476 >> MFC after: 3 days >> Sponsored by: The FreeBSD Foundation > > In wasn't an incorrect MLINK. From bsnmpagent(3): *It > 34 .Dd October 4, 2005 > 35 .Dt BSNMPAGENT 3 > 36 .Os > 37 .Sh NAME > 38 .Nm bsnmpagent , > 39 .Nm snmp_depop_t , > 40 .Nm snmp_op_t , > 41 .Nm tree , > 42 .Nm tree_size , > > I'll rename it to something else, but that's a pretty horrible > variable name/function call. ... to begin with. Thanks, -Ngie