From owner-cvs-all Mon Dec 14 17:21:34 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id RAA14601 for cvs-all-outgoing; Mon, 14 Dec 1998 17:21:34 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from dingo.cdrom.com (goldfish.pht.co.jp [210.171.55.12]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA14591; Mon, 14 Dec 1998 17:21:29 -0800 (PST) (envelope-from mike@dingo.cdrom.com) Received: from dingo.cdrom.com (localhost [127.0.0.1]) by dingo.cdrom.com (8.9.1/8.8.8) with ESMTP id RAA01309; Mon, 14 Dec 1998 17:19:29 -0800 (PST) (envelope-from mike@dingo.cdrom.com) Message-Id: <199812150119.RAA01309@dingo.cdrom.com> X-Mailer: exmh version 2.0.2 2/24/98 To: Eivind Eklund cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/isa labpc.c In-reply-to: Your message of "Sun, 13 Dec 1998 15:25:29 PST." <199812132325.PAA16418@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 14 Dec 1998 17:19:28 -0800 From: Mike Smith Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > eivind 1998/12/13 15:25:29 PST > > Modified files: > sys/i386/isa labpc.c > Log: > Fix typo - sizeof(struct crtl *) -> sizeof(struct ctrl *). > > XXX This still assume that bzero() over a field create null-pointers, > which seems a chancy proposition at best. This is assumed by many portions of the kernel; you're welcome to point out a system where we're likely to run and on which this isn't a valid assumption. You might also want to consider it in the context of my last comment about structure field initialisers... -- \\ Sometimes you're ahead, \\ Mike Smith \\ sometimes you're behind. \\ mike@smith.net.au \\ The race is long, and in the \\ msmith@freebsd.org \\ end it's only with yourself. \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message