From owner-freebsd-perl@freebsd.org  Sun Dec 25 15:46:15 2016
Return-Path: <owner-freebsd-perl@freebsd.org>
Delivered-To: freebsd-perl@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4C3E6C8E5A8
 for <freebsd-perl@mailman.ysv.freebsd.org>;
 Sun, 25 Dec 2016 15:46:15 +0000 (UTC)
 (envelope-from fjo-lists@ogris.de)
Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3])
 by mx1.freebsd.org (Postfix) with ESMTP id 386E314AF
 for <freebsd-perl@freebsd.org>; Sun, 25 Dec 2016 15:46:15 +0000 (UTC)
 (envelope-from fjo-lists@ogris.de)
Received: by mailman.ysv.freebsd.org (Postfix)
 id 34EFBC8E5A7; Sun, 25 Dec 2016 15:46:15 +0000 (UTC)
Delivered-To: perl@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 32D39C8E5A6
 for <perl@mailman.ysv.freebsd.org>; Sun, 25 Dec 2016 15:46:15 +0000 (UTC)
 (envelope-from fjo-lists@ogris.de)
Received: from box2.ogris.net (box2.ogris.net [IPv6:2a03:4000:6:2157::1])
 by mx1.freebsd.org (Postfix) with ESMTP id E89AA14AE
 for <perl@FreeBSD.org>; Sun, 25 Dec 2016 15:46:14 +0000 (UTC)
 (envelope-from fjo-lists@ogris.de)
Received: from [192.168.0.10] (p4FC2F54A.dip0.t-ipconnect.de [79.194.245.74])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128
 bits)) (No client certificate requested)
 by box2.ogris.net (Postfix) with ESMTPSA id 833EACC1E
 for <perl@FreeBSD.org>; Sun, 25 Dec 2016 16:46:12 +0100 (CET)
From: "Felix J. Ogrs" <fjo-lists@ogris.de>
Subject: graphics/p5-GD doesn't detect libgd > 2.0.33
To: perl@FreeBSD.org
Message-ID: <5699f3bc-f5e7-9a3b-5474-fb5b1322c42f@ogris.de>
Date: Sun, 25 Dec 2016 16:46:11 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------DFA3CE7D5CE0BCDF33A1BDF3"
X-Content-Filtered-By: Mailman/MimeDel 2.1.23
X-BeenThere: freebsd-perl@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: maintainer of a number of perl-related ports
 <freebsd-perl.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-perl>,
 <mailto:freebsd-perl-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-perl/>
List-Post: <mailto:freebsd-perl@freebsd.org>
List-Help: <mailto:freebsd-perl-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-perl>,
 <mailto:freebsd-perl-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Dec 2016 15:46:15 -0000

This is a multi-part message in MIME format.
--------------DFA3CE7D5CE0BCDF33A1BDF3
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

both Build.PL and Makefile.PL of p5-GD-2.56 do not correctly parse the version of libgd as returned by gdlib-config. Excerpt from Makefile.PL line 302:

my ($minor)    = $version =~ /^2\.\d+\.(\d+)$/;
$$options     .= " GD_UNCLOSEDPOLY GD_ANIMGIF GD_FTCIRCLE VERSION_33" if defined($minor) && $minor >= 33;

The above options GD_* were introduced as of libgd 2.0.33. But, current version is 2.2.3. Thus, the check fails. I'm proposing a trivial fix:

my ($release, $major, $minor) = $version =~ /^(\d+)\.(\d+)\.(\d+)$/;
$$options                    .= " GD_UNCLOSEDPOLY GD_ANIMGIF GD_FTCIRCLE VERSION_33" if defined($minor) && ($release > 2 || ($release == 2 && $major > 0) || ($release == 2 && $major == 0 && $minor >= 33));

Patches are attached.

BR,
Felix

--------------DFA3CE7D5CE0BCDF33A1BDF3
Content-Type: text/plain; charset=UTF-8;
 name="patch-Build.PL.1"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="patch-Build.PL.1"

LS0tIEJ1aWxkLlBMLm9yaWcJMjAxNi0xMi0xMyAyMDoyMjozMC4zNDg1NTAwMDAgKzAxMDAK
KysrIEJ1aWxkLlBMCTIwMTYtMTItMTMgMjA6MjM6MDEuODIwOTU1MDAwICswMTAwCkBAIC0y
ODAsOCArMjgwLDggQEAKICAgKCQkbGliX2dkX3BhdGggPSAkbGliZGlyKSA9fiBzIS9bXi9d
KyQhITsKICAgJCRvcHRpb25zICAgICAgPSAkZmVhdHVyZXM7CiAKLSAgbXkgKCRtaW5vcikg
ICAgPSAkdmVyc2lvbiA9fiAvXjJcLlxkK1wuKFxkKykkLzsKLSAgJCRvcHRpb25zICAgICAu
PSAiIEdEX1VOQ0xPU0VEUE9MWSBHRF9BTklNR0lGIEdEX0ZUQ0lSQ0xFIFZFUlNJT05fMzMi
IGlmIGRlZmluZWQoJG1pbm9yKSAmJiAkbWlub3IgPj0gMzM7CisgIG15ICgkcmVsZWFzZSwg
JG1ham9yLCAkbWlub3IpID0gJHZlcnNpb24gPX4gL14oXGQrKVwuKFxkKylcLihcZCspJC87
CisgICQkb3B0aW9ucyAgICAgICAgICAgICAgICAgICAgLj0gIiBHRF9VTkNMT1NFRFBPTFkg
R0RfQU5JTUdJRiBHRF9GVENJUkNMRSBWRVJTSU9OXzMzIiBpZiBkZWZpbmVkKCRtaW5vcikg
JiYgKCRyZWxlYXNlID4gMiB8fCAoJHJlbGVhc2UgPT0gMiAmJiAkbWFqb3IgPiAwKSB8fCAo
JHJlbGVhc2UgPT0gMiAmJiAkbWFqb3IgPT0gMCAmJiAkbWlub3IgPj0gMzMpKTsKIAogICBt
eSBAY29ycmVjdF9pbmMgPSBtYXAge3MvXi1JLy8gJiYgJF99IHNwbGl0IC9ccysvLCRjZmxh
Z3M7CiAgIGNoZWNrX2Zvcl9zdHJheV9oZWFkZXJzKCRpbmNsdWRlZGlyLEBjb3JyZWN0X2lu
Yyk7Cg==
--------------DFA3CE7D5CE0BCDF33A1BDF3--