Skip site navigation (1)Skip section navigation (2) 
Date:      Sun, 19 Mar 2006 08:03:46 +1100 (EST)
From:      Edwin Groothuis <edwin@mavetju.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/94659: [patch partly] java/jakarta-commons-pool doesn't build with jdk15
Message-ID:  <20060318210346.DF0EB265@k7.mavetju>
Resent-Message-ID: <200603182110.k2ILA9Z4011255@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help 

>Number:         94659
>Category:       ports
>Synopsis:       [patch partly] java/jakarta-commons-pool doesn't build with jdk15
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 18 21:10:09 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Edwin Groothuis
>Release:        FreeBSD 6.0-RELEASE i386
>Organization:
-
>Environment:
System: FreeBSD k7.mavetju 6.0-RELEASE FreeBSD 6.0-RELEASE #0: Thu Nov 3 09:36:13 UTC 2005 root@x64.samsco.home:/usr/obj/usr/src/sys/GENERIC i386

java version "1.5.0-p2"

>Description:

When trying to compile java/jakarta-commons-pool, I get:

    [javac] /usr/ports/java/jakarta-commons-pool/work/commons-pool-1.2/src/java/org/apache/commons/pool/impl/StackKeyedObjectPool.java:238: as of release 1.5, 'enum' is a keyword, and may not be used as an identifier
    [javac] (try -source 1.4 or lower to use 'enum' as an identifier)
    [javac]                 Enumeration enum = stack.elements();
    [javac]                             ^

After fixing that, it comes up with:

compile:
    [javac] Compiling 19 source files to /usr/ports/java/jakarta-commons-pool/work/commons-pool-1.2/build/classes
    [javac] /usr/ports/java/jakarta-commons-pool/work/commons-pool-1.2/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java:23: warning: [deprecation] org.apache.commons.collections.CursorableLinkedList in org.apache.commons.collections has been deprecated
    [javac] import org.apache.commons.collections.CursorableLinkedList;
    [javac]                                       ^

And I don't know what to do with that one...

>How-To-Repeat:
>Fix:

--- src/java/org/apache/commons/pool/impl/StackKeyedObjectPool.java.orig       Sun Mar 19 07:59:00 2006
+++ src/java/org/apache/commons/pool/impl/StackKeyedObjectPool.java     Sun Mar 19 07:59:19 2006
@@ -235,10 +235,10 @@
             return;
         } else {
             if(null != _factory) {
-                Enumeration enum = stack.elements();
-                while(enum.hasMoreElements()) {
+                Enumeration _enum = stack.elements();
+                while(_enum.hasMoreElements()) {
                     try {
-                        _factory.destroyObject(key,enum.nextElement());
+                        _factory.destroyObject(key,_enum.nextElement());
                     } catch(Exception e) {
                         // ignore error, keep destroying the rest
                     }

--- src/java/org/apache/commons/pool/impl/StackObjectPool.java.orig     Sun Mar 19 07:59:59 2006
+++ src/java/org/apache/commons/pool/impl/StackObjectPool.java  Sun Mar 19 08:00:10 2006
@@ -196,10 +196,10 @@
     public synchronized void clear() {
         assertOpen();
         if(null != _factory) {
-            Enumeration enum = _pool.elements();
-            while(enum.hasMoreElements()) {
+            Enumeration _enum = _pool.elements();
+            while(_enum.hasMoreElements()) {
                 try {
-                    _factory.destroyObject(enum.nextElement());
+                    _factory.destroyObject(_enum.nextElement());
                 } catch(Exception e) {
                     // ignore error, keep destroying the rest
                 }

>Release-Note:
>Audit-Trail:
>Unformatted:

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060318210346.DF0EB265>