Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 02 Nov 2016 08:45:54 +0000
From:      bugzilla-noreply@freebsd.org
To:        multimedia@FreeBSD.org
Subject:   maintainer-feedback requested: [Bug 213999] multimedia/livestreamer: Unnecessary requests1 dependency conflic with other ports that depend on www/py-requests
Message-ID:  <bug-213999-12827-543IbRKFix@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-213999-12827@https.bugs.freebsd.org/bugzilla/>
References:  <bug-213999-12827@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
Kubilay Kocak <koobs@FreeBSD.org> has asked multimedia@FreeBSD.org for
maintainer-feedback:
Bug 213999: multimedia/livestreamer: Unnecessary requests1 dependency confl=
ic
with other ports that depend on www/py-requests
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213999



--- Comment #2 from Kubilay Kocak <koobs@FreeBSD.org> ---
Thank you for the patch.

Could you please run livestreamers test suite (with `python-x.y setup.py te=
st`
in WKRSRC after extracting) to confirm that tests pass with requests 2.x.

I also note in setup.py, the following, which is a good indication that
requests 2.x support is OK:

# requests 2.0 does not work correctly on Python <2.6.3
if (version_info[0] =3D=3D 2 and version_info[1] =3D=3D 6 and version_info[=
2] < 3):
    deps.append("requests>=3D1.0,<2.0")
else:
deps.append("requests>=3D1.0,<3.0")

For reference, all ports depending on www/py-requests in the past were chan=
ged
to requests1 [1][2] when py-requests was updated to 2.x, allowing individual
port maintainers to make the change to the later version themselves.

[1] https://svnweb.freebsd.org/ports?view=3Drevision&revision=3D341384
[2] https://svnweb.freebsd.org/ports?view=3Drevision&revision=3D341385



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-213999-12827-543IbRKFix>