From owner-svn-src-all@freebsd.org Fri May 20 18:00:50 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5F4D0B44900 for ; Fri, 20 May 2016 18:00:50 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm31-vm6.bullet.mail.bf1.yahoo.com (nm31-vm6.bullet.mail.bf1.yahoo.com [72.30.239.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 196C41E90 for ; Fri, 20 May 2016 18:00:50 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1463765524; bh=GZ+FZUX5hL1FsXdgwrEkk6a0vhxBVUcU7ZKMfpr45aY=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=U67hnH6SjqX8iK/Es+maI8b9MHYv0vQJdxQG6peDIfEXnnAwbw6cJY9uLYOvlKnKQ7UwkLG2ir3TwKRLb/hqNasZ03OALRaldyYopFzVuYrHWja/g69TfgPQVrP1Z9ZiaNfptBP6h5yOI6oIjgZ7inHN8DiCsTvlvGSYxP1pud90LfLNdVDbzr+kr/DlFIQEfDgo9QkLLuylmxtF77DkGp54coBG41G/Fic+Kk8JJogt1u8u86A2I0YRUceQPq+qXd1417s4IK7iRVbOFR/vlHU5n2XNzQLC7wyQqHQY1WBT50LtnD/mtmo8PkAmaDsrJ4Dqa9tG5nqLowaePtB92Q== Received: from [66.196.81.173] by nm31.bullet.mail.bf1.yahoo.com with NNFMP; 20 May 2016 17:32:04 -0000 Received: from [98.139.213.14] by tm19.bullet.mail.bf1.yahoo.com with NNFMP; 20 May 2016 17:32:04 -0000 Received: from [127.0.0.1] by smtp114.mail.bf1.yahoo.com with NNFMP; 20 May 2016 17:32:04 -0000 X-Yahoo-Newman-Id: 642115.13317.bm@smtp114.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: R9vm7DQVM1kO9MIx7qA923zwk9ROrPB5n1Kl_P5C4CnRnXc zc4L4bSdARCqEmAFBmrcUysbgGSU7JWcpzGqQ.LZ06lP0ZCJzzT5EXc3zchU T1I80jVO7aelHS15LADGIMTc9hdyWNAy7g4vGMPVl7gaTcuP6tUfF33losra _iIHKRipEOjUbH203HGUdtk9T7hfQJu8a.vXNv00_dwhctmhBg_2tTyMwJ9O k8wXQ.4BGUE.3aFdMH4ysdmxsy422BxZr545nnTV9uF830kvzmOx7bUm0ghJ 0PmtlLdNg0eusc7ohnO2Z_3pCuen_5KhXJBQmzByVRORl2hlzIctwsHLaqOs EQROZUOIv3SkI4TRADwukPdOCN8H6mVV2P5njWXjLZ8qjKfK3NPs_aUFqaqX Wc56ZJwgan7LncEFqoYVEGEvfwtdvQa2JrEi20OOrGUiv4IZwZ40.JZHjO8Y 5jtXDjY5PNT7iX9vhzp.Z9Gje50jZ53VFmRR3UcgZyyns07dgIqco8NNSOt5 UFNQeqCRgkMDfWhDs8RejUVrf3uT3.PH1 X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r300301 - head/contrib/gcc To: Ed Schouten References: <201605201436.u4KEanoi031012@repo.freebsd.org> Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Pedro Giffuni Message-ID: <573F4A0B.8050803@FreeBSD.org> Date: Fri, 20 May 2016 12:31:55 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2016 18:00:50 -0000 On 20/05/2016 12:23, Ed Schouten wrote: > Hi Pedro, > > 2016-05-20 16:36 GMT+02:00 Pedro F. Giffuni : >> + tree anon = NULL_TREE; > This initialization shouldn't be needed, right? The value is always > assigned before used. > Yes, you are right. However do note that anon is used only within an if() so it is rather sane to have it initialized JIC we hit a bogus compiler. The code came directly from OpenBSD, which still uses that crappy compiler for everything, so I don't want to play experiments :). Pedro.