From owner-cvs-src@FreeBSD.ORG Tue Aug 31 21:12:44 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 31B5716A4CE; Tue, 31 Aug 2004 21:12:44 +0000 (GMT) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id F16C043D1D; Tue, 31 Aug 2004 21:12:43 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.34] (adsl-67-127-84-57.dsl.snfc21.pacbell.net [67.127.84.57]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id i7VLCfjn009508; Tue, 31 Aug 2004 14:12:41 -0700 Message-ID: <4134E9C8.4020502@root.org> Date: Tue, 31 Aug 2004 14:12:40 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.7 (X11/20040702) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "M. Warner Losh" References: <200408302135.i7ULZYQx028502@repoman.freebsd.org> <20040831070313.GC30959@ip.net.ua> <4134A9E9.7090008@root.org> <20040831.144338.66325058.imp@bsdimp.com> In-Reply-To: <20040831.144338.66325058.imp@bsdimp.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: ru@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/fdc fdc_acpi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Aug 2004 21:12:44 -0000 M. Warner Losh wrote: > In message: <4134A9E9.7090008@root.org> > Nate Lawson writes: > : Ruslan Ermilov wrote: > : > On Mon, Aug 30, 2004 at 09:35:34PM +0000, Nate Lawson wrote: > : > > : >>njl 2004-08-30 21:35:34 UTC > : >> > : >> FreeBSD src repository > : >> > : >> Modified files: > : >> sys/dev/fdc fdc_acpi.c > : >> Log: > : >> Fix _FDI drive type probing. The new fd child is not an ACPI device while > : >> the old one is. Hence we need to evaluate the old one for _FDI since it > : >> has a valid ACPI_HANDLE ivar. This is a minimal fix. Make a note that a > : >> more complete one is to make fdc support the ACPI_HANDLE ivar for its > : >> children. > : >> > : >> This and the previous change are MT5 candidates. > : >> > : >> Revision Changes Path > : >> 1.5 +10 -3 src/sys/dev/fdc/fdc_acpi.c > : >> > : > > : > Should I retry on my ThinkPad 600X with these two changes? > : > : Sure but I think yours was a resource problem and you don't have _FDE > : probing. > > I'm working the resource problem right now... My hero. :) -Nate