From owner-freebsd-current Fri May 26 13:17:31 2000 Delivered-To: freebsd-current@freebsd.org Received: from mass.cdrom.com (adsl-63-206-88-224.dsl.snfc21.pacbell.net [63.206.88.224]) by hub.freebsd.org (Postfix) with ESMTP id 8A81337B5A7; Fri, 26 May 2000 13:17:28 -0700 (PDT) (envelope-from msmith@mass.cdrom.com) Received: from mass.cdrom.com (localhost [127.0.0.1]) by mass.cdrom.com (8.9.3/8.9.3) with ESMTP id NAA00847; Fri, 26 May 2000 13:18:05 -0700 (PDT) (envelope-from msmith@mass.cdrom.com) Message-Id: <200005262018.NAA00847@mass.cdrom.com> X-Mailer: exmh version 2.1.1 10/15/1999 To: Poul-Henning Kamp Cc: Mike Smith , FreeBSD-current Subject: Re: HEADS UP Re: cvs commit: src/crypto/openssh/pam_ssh pam_ssh.c src/gnu/usr.bin/binutils/gdb freebsd-uthread.c src/include mpool.h src/lib/libc/net name6.c src/lib/libc_r/uthread pthread_private.h uthread_file.c src/lib/libncp ncpl_rcfile.c src/lib/libstand if_ether.h ... In-reply-to: Your message of "Fri, 26 May 2000 08:38:20 +0200." <9833.959323100@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 26 May 2000 13:18:04 -0700 From: Mike Smith Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > In message <200005252326.QAA02413@mass.cdrom.com>, Mike Smith writes: > >> >I objected to a recent commit hiding the fact that this is > >> >"(elm)->field.sle_next". Anyway, curelm must be a pointer to a struct. > >> >Not just any struct; the struct must contain a "field" declared using > >> >SLIST_ENTRY(). > >> > >> It could be an union or class as well... > > > >It would not be very useful if it were a union; the class issue is valid > >(although you could trivially use a struct contained within a class and a > >parent reference) but definitely not a good enough argument to support > >the massive breakage this otherwise entails. > > I have yet to see any signs of "massive breakage". Try "source-level incompatibility with everyone else that uses these interfaces" (eg. all the other BSDs, OS/X, AIX, etc.) The queue macros are a stable, widely-used API. If you're going to change their calling conventions, simple commonsense behooves you to rename them as well. -- \\ Give a man a fish, and you feed him for a day. \\ Mike Smith \\ Tell him he should learn how to fish himself, \\ msmith@freebsd.org \\ and he'll hate you for a lifetime. \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message