Date: Sat, 14 Sep 2013 12:25:38 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Olli Hauer <ohauer@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r327257 - head/devel/cvsd Message-ID: <20130914102538.GN33103@ithaqua.etoilebsd.net> In-Reply-To: <201309140959.r8E9xSGm023148@svn.freebsd.org> References: <201309140959.r8E9xSGm023148@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--N/GrjenRD+RJfyz+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 14, 2013 at 09:59:28AM +0000, Olli Hauer wrote: > Author: ohauer > Date: Sat Sep 14 09:59:28 2013 > New Revision: 327257 > URL: http://svnweb.freebsd.org/changeset/ports/327257 >=20 > Log: > - fix r327153, cvs is only required > .if ${OSVERSION} > 1000000 As for the uucp thing, this is noop, cvs is required everywhere except that= as base already provides it on < 10.0 then /usr/bin/cvs will satisfy the dependency. Plus if somone do build 9.* WITHOUT_CVS and try to install cvsd it will fai= l. The only thing that is satisfied by this OSVERSION checking is tinderbox be= cause tinderbox is failing at properly gather the dependency from *inside* the ta= rget! crees is iirc working on the issue, but that is a tinderbox issue for very = long. If you want to satisfy both, probably the good direction if something like: =2Eif !exists(${DESTDIR}/usr/bin/cvs) || ${OSVERSION} > 1000000 The deps goes here =2Eendif but imho that is lot of complexity to satisfy a tinderbox design issue. regards, Bapt --N/GrjenRD+RJfyz+ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlI0OaIACgkQ8kTtMUmk6Ew8KwCfTMFrme9PyAJ4yqUDJsEsXA20 u1IAn2oXy62NXdlN1e3SX/pG+1Q7bgZx =OXCh -----END PGP SIGNATURE----- --N/GrjenRD+RJfyz+--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130914102538.GN33103>