From owner-cvs-all Mon Feb 3 5: 7:45 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 02A2837B401; Mon, 3 Feb 2003 05:07:44 -0800 (PST) Received: from axl.seasidesoftware.co.za (axl.seasidesoftware.co.za [196.31.7.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id EE0A443F79; Mon, 3 Feb 2003 05:07:42 -0800 (PST) (envelope-from sheldonh@starjuice.net) Received: from sheldonh by axl.seasidesoftware.co.za with local (Exim 4.10) id 18fgK4-000Acy-00; Mon, 03 Feb 2003 15:07:40 +0200 Date: Mon, 3 Feb 2003 15:07:40 +0200 From: Sheldon Hearn To: "Tim J. Robbins" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/sh jobs.c Message-ID: <20030203130740.GI30972@starjuice.net> Mail-Followup-To: "Tim J. Robbins" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200301270741.h0R7fCJe032467@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200301270741.h0R7fCJe032467@repoman.freebsd.org> User-Agent: Mutt/1.5.3i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On (2003/01/26 23:41), Tim J. Robbins wrote: > Modified files: > bin/sh jobs.c > Log: > Ensure that the TTY file descriptor is greater than or equal to 10 so that > it doesn't interfere with the user's redirections. Could you add how the magic number 10 was calculated to the comment you inserted? Also, it may be better for the comment to appear before the first use of the magic number 10. Also, it may be better to use a macro to represent the magic number 10, since it's used multiple times. Ciao, Sheldon. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message