From owner-cvs-all@FreeBSD.ORG Mon Mar 19 09:15:34 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AAFBD16A408 for ; Mon, 19 Mar 2007 09:15:34 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id 1F7F313C4EA for ; Mon, 19 Mar 2007 09:15:33 +0000 (UTC) (envelope-from andre@freebsd.org) Received: (qmail 82862 invoked from network); 19 Mar 2007 08:18:18 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 19 Mar 2007 08:18:18 -0000 Message-ID: <45FE4E72.8000306@freebsd.org> Date: Mon, 19 Mar 2007 09:48:50 +0100 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.10 (Windows/20070221) MIME-Version: 1.0 To: Kip Macy References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "gnn@freebsd.org" , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: IPv6 breakage in recent changes - Re: cvs commit: src/sys/netinet tcp_syncache.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Mar 2007 09:15:34 -0000 Kip Macy wrote: >> With Andre's most recent changes what is the result? >> >> Also, is this all over localhost or? > > Andre's commit fixed the problem. Looking at the fix the problem > couldn't have been isolated to localhost. My original patch had two problems in syncache that broke IPv6 independently. The first was a C error where I missed a 'else' in the #ifdef IPv6 mess and the second got the offset for the IPv6 checksum calculation wrong because I missed to adjust it to the new realities. Tor's quickly diagnosed the problem and sent a patch which, due to some scheduling mismatch, I committed only with delay. I'm sorry for the extended breakage period this caused. I thought I had tested IPv6 as well but as it turns out I have changed /etc/hosts to use IPv4 first instead of IPv6 as is the default. We should think of doing this in -current for 7.0 as well. IPv6 is quite a bit slower than IPv4 still and everything that uses localhost is affected by it. -- Andre