From owner-p4-projects@FreeBSD.ORG Fri Jan 5 19:27:36 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 9F1C216A494; Fri, 5 Jan 2007 19:27:36 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 79F7116A403; Fri, 5 Jan 2007 19:27:36 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id EC90E13C4A7; Fri, 5 Jan 2007 19:27:35 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id l05JRXr3041343; Fri, 5 Jan 2007 14:27:34 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Roman Divacky Date: Fri, 5 Jan 2007 12:31:59 -0500 User-Agent: KMail/1.9.1 References: <200701050754.l057s5bU066108@repoman.freebsd.org> In-Reply-To: <200701050754.l057s5bU066108@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200701051231.59354.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 05 Jan 2007 14:27:34 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2414/Thu Jan 4 20:41:51 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Perforce Change Reviews Subject: Re: PERFORCE change 112534 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jan 2007 19:27:37 -0000 On Friday 05 January 2007 02:54, Roman Divacky wrote: > http://perforce.freebsd.org/chv.cgi?CH=112534 > > Change 112534 by rdivacky@rdivacky_witten on 2007/01/05 07:53:57 > > Dont lock em in a case of just using em->shared->group_pid because > the group_pid never changes. Is em->shared static for the lifetime of an em object? > Affected files ... > > .. //depot/projects/linuxolator/src/sys/compat/linux/linux_misc.c#50 edit > .. //depot/projects/linuxolator/src/sys/compat/linux/linux_signal.c#9 edit > > Differences ... > > ==== //depot/projects/linuxolator/src/sys/compat/linux/linux_misc.c#50 (text+ko) ==== > > @@ -1448,10 +1448,9 @@ > #endif > > if (linux_use26(td)) { > - em = em_find(td->td_proc, EMUL_DOLOCK); > + em = em_find(td->td_proc, EMUL_DONTLOCK); > KASSERT(em != NULL, ("getpid: emuldata not found.\n")); > td->td_retval[0] = em->shared->group_pid; > - EMUL_UNLOCK(&emul_lock); > } else { > td->td_retval[0] = td->td_proc->p_pid; > } > @@ -1490,7 +1489,7 @@ > return (0); > } > > - em = em_find(td->td_proc, EMUL_DOLOCK); > + em = em_find(td->td_proc, EMUL_DONTLOCK); > > KASSERT(em != NULL, ("getppid: process emuldata not found.\n")); > > @@ -1519,7 +1518,6 @@ > } else > td->td_retval[0] = pp->p_pid; > > - EMUL_UNLOCK(&emul_lock); > PROC_UNLOCK(pp); > > return (0); > > ==== //depot/projects/linuxolator/src/sys/compat/linux/linux_signal.c#9 (text+ko) ==== > > @@ -561,7 +561,7 @@ > > PROC_UNLOCK(p); > > - em = em_find(p, EMUL_DOLOCK); > + em = em_find(p, EMUL_DONTLOCK); > > if (em == NULL) { > #ifdef DEBUG > @@ -573,8 +573,6 @@ > if (em->shared->group_pid != args->tgid) > return ESRCH; > > - EMUL_UNLOCK(&emul_lock); > - > return linux_kill(td, &ka); > } > > -- John Baldwin