From owner-freebsd-gnome@FreeBSD.ORG Fri Apr 30 13:33:27 2004 Return-Path: Delivered-To: freebsd-gnome@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9EE5516A4D2 for ; Fri, 30 Apr 2004 13:33:27 -0700 (PDT) Received: from creme-brulee.marcuscom.com (rrcs-midsouth-24-172-16-118.biz.rr.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id C3C5243D2D for ; Fri, 30 Apr 2004 13:33:26 -0700 (PDT) (envelope-from marcus@marcuscom.com) Received: from [10.2.1.4] (vpn-client-4.marcuscom.com [10.2.1.4]) i3UKVGVi076896; Fri, 30 Apr 2004 16:31:16 -0400 (EDT) (envelope-from marcus@marcuscom.com) From: Joe Marcus Clarke To: Jeremy Messenger In-Reply-To: References: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-VN2HO182wKLkpWtGXmLJ" Organization: MarcusCom, Inc. Message-Id: <1083357217.843.29.camel@gyros> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Fri, 30 Apr 2004 16:33:37 -0400 X-Spam-Status: No, hits=-4.9 required=5.0 tests=BAYES_00 autolearn=ham version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on creme-brulee.marcuscom.com cc: freebsd-gnome@freebsd.org Subject: Re: Any plan to get bsd.gnome.mk works w/ OPTIONS? X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Apr 2004 20:33:27 -0000 --=-VN2HO182wKLkpWtGXmLJ Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Fri, 2004-04-30 at 14:06, Jeremy Messenger wrote: > On Fri, 30 Apr 2004 13:00:29 -0400, Joe Marcus Clarke=20 > wrote: >=20 > > On Fri, 2004-04-30 at 12:48, Jeremy Messenger wrote: > >> Hello, > >> > >> I am a maintainer of x11-wm/fluxbox-devel and I just changed from > >> pre-everything to OPTIONS. So, I noticed that it needs the OPTIONS to = be > >> add in the bsd.gnome.mk. Do anyone have any plan? I tried to do it by > >> myself (for now) like this for example: > >> > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >> WANT_GNOME=3D yes > >> > >> OPTIONS=3D GNOME "Enable GNOME support" on > >> > >> .include > >> > >> .if ${HAVE_GNOME:Mlibgnome}!=3D"" > >> CONFIGURE_ARGS+=3D --enable-gnome > >> .else > >> CONFIGURE_ARGS+=3D --disable-gnome > >> .endif > >> > >> .include > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >> > >> It will not listen to the OPTIONS if the user turn it off, but will=20 > >> listen > >> to the 'make -DWITHOUT_GNOME'. > > > > That's because OPTIONS are processed after bsd.gnome.mk is included in > > bsd.port.post.mk. >=20 > I did tried put OPTIONS inside and it still doesn't work. No, what I mean is that bsd.gnome.mk is included in bsd.port.mk BEFORE the OPTIONS are looked at. Therefore, it won't matter what you do in your port's Makefile, OPTIONS will not affect HAVE_GNOME. >=20 > >> I am wondering what are the plan for this like remove GNOME from OPTIO= NS > >> and it will be done by automatic by bsd.gnome.mk or should I keep GNOM= E=20 > >> in > >> OPTIONS? Just want to ask so I can have it ready early. :-) > > > > There is no plan to add OPTIONS directly into bsd.gnome.mk. >=20 > Well I think we will need it later, because it will not can tell what's=20 > default of off and on. I think, it needs to have something like if=20 > libgnome exists then it is on in the OPTIONS. That would require some work to bsd.port.mk and bsd.gnome.mk. You're welcome to take a crack at it. >=20 > > However, OPTIONS may get an overhaul at some point so that the above wi= ll > > work. For now, I would leave things to bsd.gnome.mk, or add another che= ck > > in your Makefile: > > > > .if ${HAVE_GNOME:Mlibgnome}!=3D"" && !defined(WITHOUT_GNOME) >=20 > It still doesn't make any sense to me. Let's say if I want it to be off b= y=20 > default for example as opposite, since I have libgnome and I can test it=20 > that way. It should be same idea as user that who doesn't has any libgnom= e=20 > install and want to enable WITH_GNOME. >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > WANT_GNOME=3D yes >=20 > OPTIONS=3D GNOME "Enable GNOME support" off >=20 > .include >=20 > .if ${HAVE_GNOME:Mlibgnome}!=3D"" && defined(WITH_GNOME) > CONFIGURE_ARGS+=3D --enable-gnome > .else > CONFIGURE_ARGS+=3D --disable-gnome > .endif >=20 > .include > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > It works fine with OPTIONS, but what if I have the WITH_BATCH define when= =20 > I have libgnome exists? It will not work very well with the WITH_BATCH=20 > define. Only a solution to me so far is to not use HAVE_GNOME. Yes, that will not work in this example. Though you could do something like: .if ${HAVE_GNOME:Mlibgnome}!=3D"" || defined(WITH_GNOME) That's one of the problems with OPTIONS now. The negative and positive scenarios are not well-defined. What I've decided to do myself is not use OPTIONS for things that are auto-detected. Joe >=20 > Cheers, > Mezz >=20 > > Joe > > > >> > >> Cheers, > >> Mezz --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-VN2HO182wKLkpWtGXmLJ Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBAkrghb2iPiv4Uz4cRAnG+AJ4m7kZ7lIW+b2bnA8PdQ5PobL7q5gCdHc91 o2a7GkmWzxVy43lMffQoVtY= =uyVq -----END PGP SIGNATURE----- --=-VN2HO182wKLkpWtGXmLJ--