Date: Fri, 30 Apr 2004 16:33:37 -0400 From: Joe Marcus Clarke <marcus@marcuscom.com> To: Jeremy Messenger <mezz7@cox.net> Cc: freebsd-gnome@freebsd.org Subject: Re: Any plan to get bsd.gnome.mk works w/ OPTIONS? Message-ID: <1083357217.843.29.camel@gyros> In-Reply-To: <opr6968xsj8ckrg5@smtp.central.cox.net> References: <opr693mawm8ckrg5@smtp.central.cox.net> <opr6968xsj8ckrg5@smtp.central.cox.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-VN2HO182wKLkpWtGXmLJ
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Fri, 2004-04-30 at 14:06, Jeremy Messenger wrote:
> On Fri, 30 Apr 2004 13:00:29 -0400, Joe Marcus Clarke=20
> <marcus@marcuscom.com> wrote:
>=20
> > On Fri, 2004-04-30 at 12:48, Jeremy Messenger wrote:
> >> Hello,
> >>
> >> I am a maintainer of x11-wm/fluxbox-devel and I just changed from
> >> pre-everything to OPTIONS. So, I noticed that it needs the OPTIONS to =
be
> >> add in the bsd.gnome.mk. Do anyone have any plan? I tried to do it by
> >> myself (for now) like this for example:
> >>
> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> >> WANT_GNOME=3D yes
> >>
> >> OPTIONS=3D GNOME "Enable GNOME support" on
> >>
> >> .include <bsd.port.pre.mk>
> >>
> >> .if ${HAVE_GNOME:Mlibgnome}!=3D""
> >> CONFIGURE_ARGS+=3D --enable-gnome
> >> .else
> >> CONFIGURE_ARGS+=3D --disable-gnome
> >> .endif
> >>
> >> .include <bsd.port.post.mk>
> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> >>
> >> It will not listen to the OPTIONS if the user turn it off, but will=20
> >> listen
> >> to the 'make -DWITHOUT_GNOME'.
> >
> > That's because OPTIONS are processed after bsd.gnome.mk is included in
> > bsd.port.post.mk.
>=20
> I did tried put OPTIONS inside and it still doesn't work.
No, what I mean is that bsd.gnome.mk is included in bsd.port.mk BEFORE
the OPTIONS are looked at. Therefore, it won't matter what you do in
your port's Makefile, OPTIONS will not affect HAVE_GNOME.
>=20
> >> I am wondering what are the plan for this like remove GNOME from OPTIO=
NS
> >> and it will be done by automatic by bsd.gnome.mk or should I keep GNOM=
E=20
> >> in
> >> OPTIONS? Just want to ask so I can have it ready early. :-)
> >
> > There is no plan to add OPTIONS directly into bsd.gnome.mk.
>=20
> Well I think we will need it later, because it will not can tell what's=20
> default of off and on. I think, it needs to have something like if=20
> libgnome exists then it is on in the OPTIONS.
That would require some work to bsd.port.mk and bsd.gnome.mk. You're
welcome to take a crack at it.
>=20
> > However, OPTIONS may get an overhaul at some point so that the above wi=
ll
> > work. For now, I would leave things to bsd.gnome.mk, or add another che=
ck
> > in your Makefile:
> >
> > .if ${HAVE_GNOME:Mlibgnome}!=3D"" && !defined(WITHOUT_GNOME)
>=20
> It still doesn't make any sense to me. Let's say if I want it to be off b=
y=20
> default for example as opposite, since I have libgnome and I can test it=20
> that way. It should be same idea as user that who doesn't has any libgnom=
e=20
> install and want to enable WITH_GNOME.
>=20
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> WANT_GNOME=3D yes
>=20
> OPTIONS=3D GNOME "Enable GNOME support" off
>=20
> .include <bsd.port.pre.mk>
>=20
> .if ${HAVE_GNOME:Mlibgnome}!=3D"" && defined(WITH_GNOME)
> CONFIGURE_ARGS+=3D --enable-gnome
> .else
> CONFIGURE_ARGS+=3D --disable-gnome
> .endif
>=20
> .include <bsd.port.post.mk>
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>=20
> It works fine with OPTIONS, but what if I have the WITH_BATCH define when=
=20
> I have libgnome exists? It will not work very well with the WITH_BATCH=20
> define. Only a solution to me so far is to not use HAVE_GNOME.
Yes, that will not work in this example. Though you could do something
like:
.if ${HAVE_GNOME:Mlibgnome}!=3D"" || defined(WITH_GNOME)
That's one of the problems with OPTIONS now. The negative and positive
scenarios are not well-defined. What I've decided to do myself is not
use OPTIONS for things that are auto-detected.
Joe
>=20
> Cheers,
> Mezz
>=20
> > Joe
> >
> >>
> >> Cheers,
> >> Mezz
--=20
PGP Key : http://www.marcuscom.com/pgp.asc
--=-VN2HO182wKLkpWtGXmLJ
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQBAkrghb2iPiv4Uz4cRAnG+AJ4m7kZ7lIW+b2bnA8PdQ5PobL7q5gCdHc91
o2a7GkmWzxVy43lMffQoVtY=
=uyVq
-----END PGP SIGNATURE-----
--=-VN2HO182wKLkpWtGXmLJ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1083357217.843.29.camel>