Date: Tue, 19 May 2015 16:30:54 +0000 From: "andrew (Andrew Turner)" <phabric-noreply@FreeBSD.org> To: freebsd-arm@freebsd.org Subject: [Differential] [Updated] D2579: PCI support for Alpine platform from Annapurna Labs Message-ID: <f962a3d61fa1964761649217276e3d59@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-y2vdtziki6lwmyrnc5ux-req@FreeBSD.org> References: <differential-rev-PHID-DREV-y2vdtziki6lwmyrnc5ux-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
andrew added a reviewer: ARM.
INLINE COMMENTS
sys/arm/annapurna/alpine/alpine_pci.c:247 So is it needed or is it always defined?
sys/arm/annapurna/alpine/alpine_pci.c:414 You have:
if (bus == 0) {
...
return (0);
} else {
...
}
The `else` case isn't needed as there is no way to get to past the if case. You could rewrite it as:
if (bus == 0) {
...
return (0);
}
...
REVISION DETAIL
https://reviews.freebsd.org/D2579
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: jpa-semihalf.com, ian, imp, andrew, jhb, onwahe-gmail-com, meloun-miracle-cz, br, sson, loos, sbruno, rpaulo
Cc: emaste, freebsd-arm
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f962a3d61fa1964761649217276e3d59>