From owner-freebsd-arm@FreeBSD.ORG  Tue May 19 16:30:54 2015
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 888F83AE
 for <freebsd-arm@freebsd.org>; Tue, 19 May 2015 16:30:54 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 506A013BD
 for <freebsd-arm@freebsd.org>; Tue, 19 May 2015 16:30:54 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t4JGUsEu092089
 for <freebsd-arm@freebsd.org>; Tue, 19 May 2015 16:30:54 GMT
 (envelope-from daemon-user@phabric-backend.isc.freebsd.org)
Received: (from daemon-user@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t4JGUswM092088;
 Tue, 19 May 2015 16:30:54 GMT (envelope-from daemon-user)
Date: Tue, 19 May 2015 16:30:54 +0000
To: freebsd-arm@freebsd.org
From: "andrew (Andrew Turner)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Updated] D2579: PCI support for Alpine platform from
 Annapurna Labs
Message-ID: <f962a3d61fa1964761649217276e3d59@localhost.localdomain>
X-Priority: 3
Thread-Topic: D2579: PCI support for Alpine platform from Annapurna Labs
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-aay5lnojfw75bfxuj2t6>
X-Phabricator-To: <PHID-USER-yhwnadxnjthofqelhkdx>
X-Phabricator-To: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-To: <PHID-USER-pns6zgllnr6ze4h7ms3o>
X-Phabricator-To: <PHID-USER-iv3vop5y36l265phkqzr>
X-Phabricator-To: <PHID-USER-xvjulcphpj66vffzpxft>
X-Phabricator-To: <PHID-USER-ueipubl3jymguf56hiqy>
X-Phabricator-To: <PHID-USER-xg6k32odbaf4pb47bvb3>
X-Phabricator-To: <PHID-USER-z3sohp34owrgdmrb4wka>
X-Phabricator-To: <PHID-USER-tpxlk4lxjhg7hlc5sext>
X-Phabricator-To: <PHID-USER-u62wa6uhdoiyjmodxchd>
X-Phabricator-To: <PHID-USER-k5bbpaejfd56ik2tjj37>
X-Phabricator-Cc: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-Cc: <PHID-MLST-stsrni3uozki6w7zubvy>
In-Reply-To: <differential-rev-PHID-DREV-y2vdtziki6lwmyrnc5ux-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-y2vdtziki6lwmyrnc5ux-req@FreeBSD.org>
Thread-Index: NjYxMzQxMmI2MjBmNTRlMzhjMzBkMTMzMmNhIFVbZT4=
Precedence: bulk
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-reviewers>, <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.20
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 May 2015 16:30:54 -0000

andrew added a reviewer: ARM.

INLINE COMMENTS
  sys/arm/annapurna/alpine/alpine_pci.c:247 So is it needed or is it always defined?
  sys/arm/annapurna/alpine/alpine_pci.c:414 You have:
    if (bus == 0) {
      ...
      return (0);
    } else {
      ...
    }
  
  The `else` case isn't needed as there is no way to get to past the if case. You could rewrite it as:
    if (bus == 0) {
      ...
      return (0);
    }
    ...

REVISION DETAIL
  https://reviews.freebsd.org/D2579

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: jpa-semihalf.com, ian, imp, andrew, jhb, onwahe-gmail-com, meloun-miracle-cz, br, sson, loos, sbruno, rpaulo
Cc: emaste, freebsd-arm