From owner-cvs-src@FreeBSD.ORG Wed Oct 18 02:27:46 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CD33516A403; Wed, 18 Oct 2006 02:27:46 +0000 (UTC) (envelope-from grehan@freebsd.org) Received: from dommail.onthenet.com.au (dommail.OntheNet.com.au [203.13.70.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5C87243D45; Wed, 18 Oct 2006 02:27:45 +0000 (GMT) (envelope-from grehan@freebsd.org) Received: from [10.33.24.110] (nat-198-95-226-228.netapp.com [198.95.226.228]) by dommail.onthenet.com.au (MOS 3.5.7-GR) with ESMTP id CFM06151 (AUTH peterg@ptree32.com.au); Wed, 18 Oct 2006 12:27:41 +1000 (EST) Message-ID: <4535915D.8010002@freebsd.org> Date: Tue, 17 Oct 2006 19:28:45 -0700 From: Peter Grehan User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.8b) Gecko/20051014 MIME-Version: 1.0 To: David Xu , obrien@freebsd.org References: <200610180209.k9I29kMa062324@repoman.freebsd.org> In-Reply-To: <200610180209.k9I29kMa062324@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/powerpc/powerpc copyinout.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Oct 2006 02:27:46 -0000 > Attempt to fix compiling problem. Not quite there, you need to add: < (void) atomic_cmpset_32(p, old, new); --- > (void) atomic_cmpset_32((volatile uint32_t *)p, old, new); I'm waiting for PR amd64/102996 to be fixed before putting powerpc into the universe target since 64-bit build hosts don't currently work :( That should help resolve some of these type of issues. David O'Brien, did you have any objection to the proposed solution in amd64/102996 ?? later, Peter.