Date: Wed, 16 Feb 2005 14:06:59 -0500 From: Jung-uk Kim <jkim@niksun.com> To: obrien@freebsd.org Cc: Coleman Kane <cokane@cokane.org> Subject: Re: [PATCH] Updated quirk-driven R3000Z patches Message-ID: <200502161406.59169.jkim@niksun.com> In-Reply-To: <20050216183628.GB83553@dragon.nuxi.com> References: <200502141722.10259.jhb@FreeBSD.org> <20050216140808.GF99724@ramen> <20050216183628.GB83553@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Boundary-00=_Tn5ECYXYqpx0fBB Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline On Wednesday 16 February 2005 01:36 pm, David O'Brien wrote: > [ PLEASE don't top-post, else I may not reply. This is a Unix list. > ] > > On Wed, Feb 16, 2005 at 02:08:08PM +0000, Coleman Kane wrote: > > Yeah the recipient of the fix just emailed me about this, I am > > guessing that the #if 0 is the uncommitable part. Is there any > > way that this can be done by the kernel (the PCI reg write, that > > is)? Is there any reason that it can't be done there? > > Yes, the "#if 0" in > http://lists.freebsd.org/mailman/htdig/freebsd-amd64/2005-January/0 >03365.html isn't commitable. > > > > All you need is the second hunk, which is commitable, I > > > believe. The first hunk has to be fixed from BIOS or manually > > > corrected by: > > Jung-uk, can you post another patch with just this fix? In a > commitable form please. Sure. Attached. Jung-uk Kim --Boundary-00=_Tn5ECYXYqpx0fBB Content-Type: text/plain; charset="iso-8859-1"; name="pci_pci.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="pci_pci.diff" Index: pci_pci.c =================================================================== RCS file: /home/ncvs/src/sys/dev/pci/pci_pci.c,v retrieving revision 1.33 diff -u -r1.33 pci_pci.c --- src/sys/dev/pci/pci_pci.c 1 Jul 2004 07:46:28 -0000 1.33 +++ src/sys/dev/pci/pci_pci.c 16 Feb 2005 19:04:30 -0000 @@ -319,6 +319,8 @@ start = sc->iobase; if (end > sc->iolimit) end = sc->iolimit; + if (start <= end) + ok = 1; } } else { ok = 1; --Boundary-00=_Tn5ECYXYqpx0fBB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200502161406.59169.jkim>