From owner-svn-src-all@freebsd.org Sun Jul 31 00:44:24 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 31E04BA2D02; Sun, 31 Jul 2016 00:44:24 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f41.google.com (mail-it0-f41.google.com [209.85.214.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B54B311DD; Sun, 31 Jul 2016 00:44:23 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f41.google.com with SMTP id j124so140526951ith.1; Sat, 30 Jul 2016 17:44:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=o9ZtoEORx5T9OoKGbOWsUMnPo9l+Kmv6RsnZ65/rfrw=; b=fyTzh8iD/LD/5DGkg8wIFT6I5rz7C/QFM4UhDiYVM189wISF/W8RwJ83ypNPUKhTCW 1tnQlGEY7bsV3mQWLvVkgcyys2cPlkwjQcS+zKm5sFFgjnN85n7AfdAEw1QarPjeeRAz qYhw3TBHigzswQItEIh+T+h58uPlCXZgZAN08ZJLLOrA2SWY+dtkTVfE37oghycRlddG cRH0Kgli9J9bEmBAHmO4hOdL7lugdbwjw4Z4Npi3XA+p5mEzL8sc8b4QjltpReWtcabc 9jDsRrpPa2EHrbmSnHodrV/31np6KLfm7xFxLOuHqf13ax4lx7Cfno9+eBnVpMLmlX+R sdMw== X-Gm-Message-State: AEkoout5R4JS9lFvVmYISYUhZ865gRG83rZaUuhcRfdKuS2/Q7KeJdoEFWZTji7wpKPDIQ== X-Received: by 10.36.66.2 with SMTP id i2mr7094669itb.53.1469925857623; Sat, 30 Jul 2016 17:44:17 -0700 (PDT) Received: from mail-it0-f47.google.com (mail-it0-f47.google.com. [209.85.214.47]) by smtp.gmail.com with ESMTPSA id u75sm4521979ita.16.2016.07.30.17.44.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 30 Jul 2016 17:44:17 -0700 (PDT) Received: by mail-it0-f47.google.com with SMTP id j124so140526863ith.1; Sat, 30 Jul 2016 17:44:17 -0700 (PDT) X-Received: by 10.36.192.9 with SMTP id u9mr51322880itf.86.1469925857131; Sat, 30 Jul 2016 17:44:17 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.36.233.67 with HTTP; Sat, 30 Jul 2016 17:44:16 -0700 (PDT) In-Reply-To: <201607302223.u6UMNWD7037665@repo.freebsd.org> References: <201607302223.u6UMNWD7037665@repo.freebsd.org> From: Conrad Meyer Date: Sat, 30 Jul 2016 17:44:16 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r303563 - head/sys/kern To: Mateusz Guzik Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jul 2016 00:44:24 -0000 On Sat, Jul 30, 2016 at 3:23 PM, Mateusz Guzik wrote: > Author: mjg > Date: Sat Jul 30 22:23:31 2016 > New Revision: 303563 > URL: https://svnweb.freebsd.org/changeset/base/303563 > > Log: > sx: increment spin_cnt before cpu_spinwait in xlock Looks like it's after cpu_spinwait instead. > > The change is a no-op only done for consistency with the rest of the file. > > Modified: > head/sys/kern/kern_sx.c > > Modified: head/sys/kern/kern_sx.c > ============================================================================== > --- head/sys/kern/kern_sx.c Sat Jul 30 22:21:48 2016 (r303562) > +++ head/sys/kern/kern_sx.c Sat Jul 30 22:23:31 2016 (r303563) > @@ -889,10 +889,10 @@ _sx_slock_hard(struct sx *sx, int opts, > GIANT_SAVE(); > while (SX_OWNER(sx->sx_lock) == x && > TD_IS_RUNNING(owner)) { > + cpu_spinwait(); > #ifdef KDTRACE_HOOKS > spin_cnt++; > #endif > - cpu_spinwait(); > } > KTR_STATE0(KTR_SCHED, "thread", > sched_tdname(curthread), "running"); >