From owner-svn-src-head@freebsd.org Tue Nov 13 18:04:36 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C6AA8112C617 for ; Tue, 13 Nov 2018 18:04:36 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1f.eu.mailhop.org (outbound1f.eu.mailhop.org [52.28.59.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 07DE870716 for ; Tue, 13 Nov 2018 18:04:35 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1542131302; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=Cb+djJRSY0MtwtSkF7oD6qwr3ANwUK939QqtsGhMdq1y9FWu9/LGNxJ103NPOWTRjUjrxrPXlKd/2 nSEQYe0mU+O8UBBS4m6Xa2xWPFL11EXpMdGI5ikK5ip9XQOKRJvS3Twgdp2jFZumosDvTTUpnJpn5c g6wbV0V+iqv4I6/ecTKXqWNX2JZmPxj+JIJbBvcJPDZaVug5YCZJOMruw2R9EDIJAvV/B1boUfUDo7 I2hceBSdWvUxsk0q+yy5U//xyXpEF0xLqKdmTLdx1YiV543pO+nqgU7FFRIYdy5bjkUvTTaWguJJ+k OJaSLFy6R6UcpUe45l0ZoEgUV/50/UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=yeXZW1ck12Tta5cmSZL7Iza63tgUX9ULygz78ujWUtM=; b=vChSEwM/atNw66ALBQiNJGUFd8WkO1/dYYCpjWwgKbVw0t+5xoHmuzRPQ7HBEk3pS++UsMFOMW+3G Rcahm5lxV9dR8EMBmfZ5C+8MXJ2vGJnPmJOJchJfffo2sOhqz7/UMkH8MYD2VuEog625TRpDuvwtIg Ba7zWKQmr+Lwv8hhqD7Bpqmkr4HPbow76bu+pv6KfrUv3GHMFmsP9Ney7Yh1bXC4QC96/8Xn6GS/Te i7XtPHE1JP+S2j/gfx0rhYazi4ckdDb/0GlLuO0JcHAwCQHURsOqc/x01JAiq9AhHmM2PvWRAtLNqg vV6M0FCCczZAJsVhOKMq7a3cqPhieaA== ARC-Authentication-Results: i=1; outbound2.eu.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=yeXZW1ck12Tta5cmSZL7Iza63tgUX9ULygz78ujWUtM=; b=XltGDgxR5JmH7sLSgWLntKTodCW7OFpEZbuTVwxHYN+jJSSa2viqRK7Bq3IPxPdJohvG7ikdOaZAb /hIarpWh2naUvH99t0/oimKl6PGX0cVxVG4sCkS5Mh8sSwU/uiQCzWVmptZ+krNwg6oa9RH091D0lL Ywrh46DK+6W71q2OnxvjdGGF48h1W6vIXcqw+Km/7rHDmipsld0ANc9+Hopm4El6o8QqQqnSl12Kbq MlMFTBqAuai1MfoRIMO/Fjv5fWGH5sVb+hBL+Wz2SMYxm+usKDsdaM+79m/I8GpGv05I2UAfPs4ksm ZfMxbbEWuwKU4WG3Q+TTvDmYBsYwXhQ== X-MHO-RoutePath: aGlwcGll X-MHO-User: 4ebbabd4-e76c-11e8-8436-3d722b9f52f0 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound2.eu.mailhop.org (Halon) with ESMTPSA id 4ebbabd4-e76c-11e8-8436-3d722b9f52f0; Tue, 13 Nov 2018 17:48:21 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id wADHmJf4097771; Tue, 13 Nov 2018 10:48:19 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1542131299.52306.208.camel@freebsd.org> Subject: Re: svn commit: r340326 - head From: Ian Lepore To: rgrimes@freebsd.org, cem@freebsd.org Cc: woodsb02@freebsd.org, src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Tue, 13 Nov 2018 10:48:19 -0700 In-Reply-To: <201811121400.wACE0JK5025628@pdx.rh.CN85.dnsmgr.net> References: <201811121400.wACE0JK5025628@pdx.rh.CN85.dnsmgr.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 07DE870716 X-Spamd-Result: default: False [-103.96 / 200.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ALLOW_DOMAIN_WHITELIST(-100.00)[freebsd.org]; HAS_XOIP(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; R_SPF_SOFTFAIL(0.00)[~all]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[outbound.mailhop.org:+]; MX_GOOD(-0.01)[cached: mx66.freebsd.org]; NEURAL_HAM_SHORT(-0.99)[-0.990,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-0.16)[asn: 16509(-0.68), country: US(-0.09)]; ARC_ALLOW(-1.00)[i=1]; ASN(0.00)[asn:16509, ipnet:52.28.0.0/16, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[60.211.177.67.zen.spamhaus.org : 127.0.0.10]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[outbound.mailhop.org]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[28.59.28.52.list.dnswl.org : 127.0.20.0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 18:04:37 -0000 On Mon, 2018-11-12 at 06:00 -0800, Rodney W. Grimes wrote: > > > > I absolutely approve of Ben's excellent addition to UPDATING, a > > text document. > At no point did I raise ANY objectection to the content > of his change, stop trying to make that the issue. > > > > > Your demands for additional scrutiny and time-wasting around code > > review are ridiculous and disproportionate, and certainly a poor > > reward for Ben's straightforward and unimpeachable effort to > > improve > > our UPDATING documentation. > My demands are reasonable, as I stated them, your ignoring them > and casting focus on my non dmeands however is pointless. > > > > > > > Ben, thank you for submitting and committing the UPDATING change > > and > > please try to ignore Rod's hyper-criticism. > What you are totally ignoring is that Ben infact TAGGED me into > the review process, causing me to process yet another email only > to go look at the review to find it had been closed by a commit > in < 4 hours total elapsed time. > > That is BULLSHIT and I am calling it BULLSHIT.  And though Ben > is the poor victom of example here, he is not the only guilty > party, and though this is a trivial change, it is not the change > that I am ranting about, but the fact that the process is > broken. > > IF YOUR GOING TO TAG SOMEONE INTO A REVIEW YOU MUST GIVE THEM > TIME TO RESPOND BEFORE YOU COMMIT, otherwise your just wasting > there time.   > > Do NOT tag me into a review if your going to commit it before > I can possibly be expected to respond.  I well rant on anyone > who does that. > > CLEAR NOW? > You seem to be very confused about phabricator and the review process. Being added to the list of reviewers in no way implies that your signoff is REQUIRED before a commit can occur. If you don't have time to jump on a review immediately, but some other committer does, then that's good enough, the process is working to perfection. -- Ian > > > > Conrad > > > > > > On Sat, Nov 10, 2018 at 5:07 PM Rodney W. Grimes > > wrote: > > > > > > > > > [ Charset UTF-8 unsupported, converting... ] > > > > > > > > On Sun, 11 Nov 2018 at 2:43 am, Rodney W. Grimes < > > > > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > > > > > > > > > > > > If your going to bother with a differential, and invite > > > > > people to > > > > > it you should give them at least 24 hours, and preferably 72 > > > > > hours > > > > > to respond to the new review.  Reviews that last < 4 hours > > > > > are not > > > > > code reviews. > > > > > > > > > > -- > > > > > Rod Grimes > > > > > rgrimes@freebsd.org > > > > > > > > > Hi Rod, > > > > > > > > Sorry. The main reason I submitted the code review is because I > > > > do not have > > > > my src commit bit, so needed to seek approval to commit. > > > All the more reason for it to wait until the people you *invited* > > > to > > > the review to have a chance to respond. > > > > > > I do not believe an "accept" in a review is an "approve to commit > > > beyond your normal scope". > > > > > > Was cem aware that he was "approving a non src committer to > > > commit > > > this change to the src tree" as your review has no mention that > > > you > > > are seeking src bit approval to commit there. > > > > > > > > > > > > > > > I felt the need to commit the UPDATING entry was time > > > > sensitive, given the > > > > change it was notifying users of had already been committed. > > > > > > > > Regards, > > > > Ben > > > > -- > > > -- > > > Rod Grimes                                                 rgrime > > > s@freebsd.org > > > > >