From owner-svn-src-all@freebsd.org Fri Aug 17 13:32:35 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 16D24106EF6B; Fri, 17 Aug 2018 13:32:35 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from forward104j.mail.yandex.net (forward104j.mail.yandex.net [IPv6:2a02:6b8:0:801:2::107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "forwards.mail.yandex.net", Issuer "Yandex CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8BF017DAB5; Fri, 17 Aug 2018 13:32:34 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from mxback5o.mail.yandex.net (mxback5o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::1f]) by forward104j.mail.yandex.net (Yandex) with ESMTP id 2C07E42A3D; Fri, 17 Aug 2018 16:32:24 +0300 (MSK) Received: from smtp1o.mail.yandex.net (smtp1o.mail.yandex.net [2a02:6b8:0:1a2d::25]) by mxback5o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 06lcY2JVz5-WOT0WL72; Fri, 17 Aug 2018 16:32:24 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1534512744; bh=zdie6jliTcyJQp3eAUYpT6TzyPbLoK/jfZsvL66Gn/Q=; h=Subject:To:Cc:References:From:Message-ID:Date:In-Reply-To; b=FdTYYIXbdPPfjj+ciVSdhdHxkgx+B6QoBWj4xI2IRZFQ7S8/q90Pwqms0rR/N1DpD qPcBQz9mvAQkG5b7ux/fwgKdCHkvaY99VaY4I4kT4AK+ES7MzOVNvvExEzbJLrWPFK fPFz0eaAnDlePN0buBkISUQTHksupQmdZ4djntYQ= Received: by smtp1o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id UmD847jquE-WNLmRgUq; Fri, 17 Aug 2018 16:32:23 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1534512743; bh=zdie6jliTcyJQp3eAUYpT6TzyPbLoK/jfZsvL66Gn/Q=; h=Subject:To:Cc:References:From:Message-ID:Date:In-Reply-To; b=bT4qMoxMI9a2DHEUNq7a6AViEnup6owXEkBFK2bi4HhU0ar3afoQJe395scJXf7kV xOB0xsFHZefvSEHOG/pnRSICJn7DAseyPo95qs4got+AomePuQiakU95Vv/oxMCUUd 8lDBBo5zitsxBB0spLER19a/x6raru1AweYIiG5M= Authentication-Results: smtp1o.mail.yandex.net; dkim=pass header.i=@yandex.ru Subject: Re: svn commit: r337736 - in head/sys: netinet netinet6 To: Alan Somers Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201808140754.w7E7sEFs018313@repo.freebsd.org> From: "Andrey V. Elsukov" Openpgp: id=E6591E1B41DA1516F0C9BC0001C5EA0410C8A17A Autocrypt: addr=bu7cher@yandex.ru; prefer-encrypt=mutual; keydata= xsBNBEwBF1kBCADB9sXFhBEUy8qQ4X63Y8eBatYMHGEFWN9ypS5lI3RE6qQW2EYbxNk7qUC5 21YIIS1mMFVBEfvR7J9uc7yaYgFCEb6Sce1RSO4ULN2mRKGHP3/Sl0ijZEjWHV91hY1YTHEF ZW/0GYinDf56sYpDDehaBF5wkWIo1+QK5nmj3vl0DIDCMNd7QEiWpyLVwECgLX2eOAXByT8B bCqVhJGcG6iFP7/B9Ll6uX5gb8thM9LM+ibwErDBVDGiOgvfxqidab7fdkh893IBCXa82H9N CNwnEtcgzh+BSKK5BgvPohFMgRwjti37TSxwLu63QejRGbZWSz3OK3jMOoF63tCgn7FvABEB AAHNIkFuZHJleSBWLiBFbHN1a292IDxhZUBmcmVlYnNkLm9yZz7CwHsEEwECACUCGwMGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheABQJMB/ruAhkBAAoJEAHF6gQQyKF6MLwH/3Ri/TZl9uo0 SepYWXOnxL6EaDVXDA+dLb1eLKC4PRBBjX29ttQ0KaWapiE6y5/AfzOPmRtHLrHYHjd/aiHX GMLHcYRXD+5GvdkK8iMALrZ28X0JXyuuZa8rAxWIWmCbYHNSBy2unqWgTI04Erodk90IALgM 9JeHN9sFqTM6zalrMnTzlcmel4kcjT3lyYw3vOKgoYLtsLhKZSbJoVVVlvRlGBpHFJI5AoYJ SyfXoN0rcX6k9X7Isp2K50YjqxV4v78xluh1puhwZyC0p8IShPrmrp9Oy9JkMX90o6UAXdGU KfdExJuGJfUZOFBTtNIMNIAKfMTjhpRhxONIr0emxxDOwE0ETAEXWQEIAJ2p6l9LBoqdH/0J PEFDY2t2gTvAuzz+8zs3R03dFuHcNbOwjvWCG0aOmVpAzkRa8egn5JB4sZaFUtKPYJEQ1Iu+ LUBwgvtXf4vWpzC67zs2dDuiW4LamH5p6xkTD61aHR7mCB3bg2TUjrDWn2Jt44cvoYxj3dz4 S49U1rc9ZPgD5axCNv45j72tggWlZvpefThP7xT1OlNTUqye2gAwQravXpZkl5JG4eOqJVIU X316iE3qso0iXRUtO7OseBf0PiVmk+wCahdreHOeOxK5jMhYkPKVn7z1sZiB7W2H2TojbmcK HZC22sz7Z/H36Lhg1+/RCnGzdEcjGc8oFHXHCxUAEQEAAcLAXwQYAQIACQUCTAEXWQIbDAAK CRABxeoEEMihegkYCAC3ivGYNe2taNm/4Nx5GPdzuaAJGKWksV+w9mo7dQvU+NmI2az5w8vw 98OmX7G0OV9snxMW+6cyNqBrVFTu33VVNzz9pnqNCHxGvj5dL5ltP160JV2zw2bUwJBYsgYQ WfyJJIM7l3gv5ZS3DGqaGIm9gOK1ANxfrR5PgPzvI9VxDhlr2juEVMZYAqPLEJe+SSxbwLoz BcFCNdDAyXcaAzXsx/E02YWm1hIWNRxanAe7Vlg7OL+gvLpdtrYCMg28PNqKNyrQ87LQ49O9 50IIZDOtNFeR0FGucjcLPdS9PiEqCoH7/waJxWp6ydJ+g4OYRBYNM0EmMgy1N85JJrV1mi5i Message-ID: Date: Fri, 17 Aug 2018 16:31:42 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mWWUn5o6axP8hW17d53NkBOxTUpMH7w5a" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Aug 2018 13:32:35 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mWWUn5o6axP8hW17d53NkBOxTUpMH7w5a Content-Type: multipart/mixed; boundary="HvPTNh4d52KObrDfnjB1dOnRmmXZU4SJz"; protected-headers="v1" From: "Andrey V. Elsukov" To: Alan Somers Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: Subject: Re: svn commit: r337736 - in head/sys: netinet netinet6 References: <201808140754.w7E7sEFs018313@repo.freebsd.org> In-Reply-To: --HvPTNh4d52KObrDfnjB1dOnRmmXZU4SJz Content-Type: multipart/mixed; boundary="------------39C66C75E0503693ED0220C5" Content-Language: en-US This is a multi-part message in MIME format. --------------39C66C75E0503693ED0220C5 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 16.08.2018 21:34, Alan Somers wrote: > On Tue, Aug 14, 2018 at 1:54 AM, Andrey V. Elsukov > wrote: >=20 > Author: ae > Date: Tue Aug 14 07:54:14 2018 > New Revision: 337736 > URL: https://svnweb.freebsd.org/changeset/base/337736 > >=20 > Log: > =C2=A0 Restore ability to send ICMP and ICMPv6 redirects. >=20 > =C2=A0 It was lost when tryforward appeared. Now ip[6]_tryforward w= ill be > enabled > =C2=A0 only when sending redirects for corresponding IP version is > disabled via > =C2=A0 sysctl. Otherwise will be used default forwarding function. >=20 > =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0221137 >=20 > This change broke the sys/netipsec/tunnel tests.=C2=A0 I don't know if = it's a > limitation of the tests, or a genuine kernel bug, but I bisected the > regression down to this change.=C2=A0 Can you please fix it? >=20 > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/8630/testReport/sys.= netipsec.tunnel/empty/v4/ I think it is because IPv4 tests use broadcast addresses in some places. The attached patch fixes the test for me. --=20 WBR, Andrey V. Elsukov --------------39C66C75E0503693ED0220C5 Content-Type: text/x-patch; name="ipsec.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="ipsec.diff" Index: tests/sys/netipsec/tunnel/utils.subr =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- tests/sys/netipsec/tunnel/utils.subr (revision 337961) +++ tests/sys/netipsec/tunnel/utils.subr (working copy) @@ -57,8 +57,8 @@ ist_v4_setup () jexec ipsecA ifconfig ${epair_LAN_A}b 192.0.2.2/30 up jexec ipsecA ifconfig ${epair_PUB_A}a 198.51.100.2/30 up jexec router ifconfig ${epair_PUB_A}b 198.51.100.1/30 up - jexec router ifconfig ${epair_PUB_B}b 198.51.100.6/30 up - jexec ipsecB ifconfig ${epair_PUB_B}a 198.51.100.7/30 up + jexec router ifconfig ${epair_PUB_B}b 198.51.100.5/30 up + jexec ipsecB ifconfig ${epair_PUB_B}a 198.51.100.6/30 up jexec ipsecB ifconfig ${epair_LAN_B}b 203.0.113.2/30 up jexec hostB ifconfig ${epair_LAN_B}a 203.0.113.1/30 up jexec ipsecA sysctl net.inet.ip.forwarding=3D1 @@ -66,7 +66,7 @@ ist_v4_setup () jexec ipsecB sysctl net.inet.ip.forwarding=3D1 jexec hostA route add default 192.0.2.2 jexec ipsecA route add default 198.51.100.1 - jexec ipsecB route add default 198.51.100.6 + jexec ipsecB route add default 198.51.100.5 jexec hostB route add default 203.0.113.2 } =20 @@ -109,7 +109,7 @@ ist_setkey() SRC_LAN=3D"192.0.2.0/24" DST_LAN=3D"203.0.113.0/24" SRC_GW=3D"198.51.100.2" - DST_GW=3D"198.51.100.7" + DST_GW=3D"198.51.100.6" else SRC_LAN=3D"2001:db8:1::/64" DST_LAN=3D"2001:db8:45::/64" --------------39C66C75E0503693ED0220C5-- --HvPTNh4d52KObrDfnjB1dOnRmmXZU4SJz-- --mWWUn5o6axP8hW17d53NkBOxTUpMH7w5a Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQEzBAEBCAAdFiEE5lkeG0HaFRbwybwAAcXqBBDIoXoFAlt2zj4ACgkQAcXqBBDI oXpXKgf/c1DcFBelAdXHV780rjVq7+8u9umfEehVd4ulPRfASj4y+A+EQF3aeShT JrQg8D6yrGVBJE7A5iX7QWHb8N26n2MCZTYgmMw5hSni20yAE1F01I21RTWKuOHz AZ5k+ZD17VVj5021kgZC/CdBomXYAtdr64sfQJWsnsqB7mY1s/I9vgTuWrCOGAi5 Y6pmonfitSQOEKtXfDaw5A3KKlY3Y71guI5JhsKn8hAwcY5kCY8blcQE8naIj93h Nv6UBpRRRC+F8fuYffyGk01WXdpaSqOZmTcbYqFhb8E3icejBxXRX1X0UIfLuDrf Mur/6RcELUxfbuHpaUkvKIf+guTIiQ== =pFQf -----END PGP SIGNATURE----- --mWWUn5o6axP8hW17d53NkBOxTUpMH7w5a--