From owner-svn-src-all@freebsd.org  Thu Jan 14 16:46:10 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 17F2DA8151E;
 Thu, 14 Jan 2016 16:46:10 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E69F81D00;
 Thu, 14 Jan 2016 16:46:09 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net
 [73.231.226.104])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 1A687B93C;
 Thu, 14 Jan 2016 11:46:08 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: NGie Cooper <yaneurabeya@gmail.com>
Cc: Steven Hartland <smh@freebsd.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r293903 - in head/sys/boot: arm/uboot efi/fdt
 efi/libefi
Date: Thu, 14 Jan 2016 07:55 -0800
Message-ID: <8690606.xvPx6EyIfQ@ralph.baldwin.cx>
User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; )
In-Reply-To: <F3E05332-F6B1-4685-812A-FD2BBB870075@gmail.com>
References: <201601140922.u0E9M1rV025146@repo.freebsd.org>
 <F3E05332-F6B1-4685-812A-FD2BBB870075@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Thu, 14 Jan 2016 11:46:08 -0500 (EST)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jan 2016 16:46:10 -0000

On Thursday, January 14, 2016 01:27:51 AM NGie Cooper wrote:
>=20
> > On Jan 14, 2016, at 01:22, Steven Hartland <smh@FreeBSD.org> wrote:=

> >=20
> > Author: smh
> > Date: Thu Jan 14 09:22:01 2016
> > New Revision: 293903
> > URL: https://svnweb.freebsd.org/changeset/base/293903
> >=20
> > Log:
> >  Fix GCC warnings causing build failure after r293724
> >=20
> >  Disable some compiler warnings for GCC (non-standard compiler) fix=
ing
> >  build failures introduced by r293724, which enabled WARNS in the E=
FI boot
> >  code, when compiling with none standard compiler (GCC).
>=20
> Disabling warnings is wrong. Here=E2=80=99s how arm could be fixed:
>=20
> $ svn diff sys/boot/
> Index: sys/boot/common/bootstrap.h
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- sys/boot/common/bootstrap.h (revision 293877)
> +++ sys/boot/common/bootstrap.h (working copy)
> @@ -32,6 +32,7 @@
>  #include <sys/types.h>
>  #include <sys/queue.h>
>  #include <sys/linker_set.h>
> +#include <time.h>
> =20
>  /*
>   * Generic device specifier; architecture-dependant=20
> @@ -332,12 +333,8 @@
>  extern struct arch_switch archsw;
> =20
>  /* This must be provided by the MD code, but should it be in the arc=
hsw? */
> -void   delay(int delay);
> -

The comment seems to be related to delay() so it should perhaps go as w=
ell?

--=20
John Baldwin