From owner-cvs-all@FreeBSD.ORG  Mon May 23 06:29:59 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.ORG
Delivered-To: cvs-all@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 562B416A41C;
	Mon, 23 May 2005 06:29:59 +0000 (GMT)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AD9A843D48;
	Mon, 23 May 2005 06:29:58 +0000 (GMT)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.13.3/8.13.3) with ESMTP id j4N6Tvkf071300;
	Mon, 23 May 2005 10:29:57 +0400 (MSD)
	(envelope-from ache@nagual.pp.ru)
DomainKey-Signature: a=rsa-sha1; s=default; d=nagual.pp.ru; c=nofws; q=dns;
	h=received:date:from:to:cc:subject:message-id:
	mail-followup-to:references:mime-version:content-type:
	content-disposition:in-reply-to:user-agent;
	b=sesI3HhfcKWnqitYHGsI90OIGAiQm0GSyVcWleyxSGBdRVP9QDwNU+nqL0hvO2M7q
	lkICLD0U3Z6o0UqWxCh1g==
Received: (from ache@localhost)
	by nagual.pp.ru (8.13.3/8.13.3/Submit) id j4N6Tv9p071299;
	Mon, 23 May 2005 10:29:57 +0400 (MSD) (envelope-from ache)
Date: Mon, 23 May 2005 10:29:57 +0400
From: Andrey Chernov <ache@nagual.pp.ru>
To: Dirk Meyer <dinoex@FreeBSD.ORG>
Message-ID: <20050523062957.GA71060@nagual.pp.ru>
Mail-Followup-To: Andrey Chernov <ache@nagual.pp.ru>,
	Dirk Meyer <dinoex@FreeBSD.ORG>, ports-committers@FreeBSD.ORG,
	cvs-ports@FreeBSD.ORG, cvs-all@FreeBSD.ORG
References: <200505222137.j4MLbn2Y086190@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200505222137.j4MLbn2Y086190@repoman.freebsd.org>
User-Agent: Mutt/1.5.9i
Cc: cvs-ports@FreeBSD.ORG, cvs-all@FreeBSD.ORG, ports-committers@FreeBSD.ORG
Subject: Re: cvs commit: ports/mail/sid-milter/files milter-sid.sh
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 May 2005 06:29:59 -0000

On Sun, May 22, 2005 at 09:37:49PM +0000, Dirk Meyer wrote:
> dinoex      2005-05-22 21:37:49 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     mail/sid-milter/files milter-sid.sh 
>   Log:
>   - add restart target
>   - fix wait subtarget
>   Suggested by:   ache


Thanx! But there are still issues (I meet them when I recently made 
dk-milter port using your sid-milter as template).

1) You don't need to install libar and its includes. Nobody uses it so 
far. In fact dk-milter originally tryes to install libar/includes too, 
making conflict, but I patch it to not do it.
2) You do't need 'sleep 1' between start & stop, because both uses wait.
3) (question) why you use cd /root at start? It works without it.

-- 
http://ache.pp.ru/