From owner-freebsd-current  Tue Nov  5  3:17:26 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6684037B401; Tue,  5 Nov 2002 03:17:25 -0800 (PST)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2819E43E4A; Tue,  5 Nov 2002 03:17:25 -0800 (PST)
	(envelope-from mux@freebsd.org)
Received: by elvis.mu.org (Postfix, from userid 1920)
	id E958DAE28A; Tue,  5 Nov 2002 03:17:24 -0800 (PST)
Date: Tue, 5 Nov 2002 03:17:24 -0800
From: Maxime Henrion <mux@freebsd.org>
To: Juli Mallett <jmallett@FreeBSD.org>
Cc: Patrick Hartling <patrick@137.org>, current@freebsd.org,
	marcel@freebsd.org
Subject: Re: uuid.h is not C++ safe
Message-ID: <20021105111724.GF26605@elvis.mu.org>
References: <3DC71B56.1050102@137.org> <20021105105813.GD26605@elvis.mu.org> <20021105105927.GE26605@elvis.mu.org> <20021105030419.A19427@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20021105030419.A19427@FreeBSD.org>
User-Agent: Mutt/1.4i
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

Juli Mallett wrote:
> * De: Maxime Henrion <mux@freebsd.org> [ Data: 2002-11-05 ]
> 	[ Subjecte: Re: uuid.h is not C++ safe ]
> > Maxime Henrion wrote:
> > > Patrick Hartling wrote:
> > > > I was just about to put the new DCE 1.1 UUID functions into use in some 
> > > > C++ code, but linking fails because the function prototypes in uuid.h 
> > > > are not protected with the __cplusplus/extern "C" bits.  It's easy 
> > > > enough for me to fix my local copy, but I'm sure this same thing could 
> > > > trip up other people.
> > > 
> > > This should be fixed with the attached patch.  Marcel, can you review
> > > and commit it please ?
> 
> Oops, I probably should have pinged Marcel about this, now that I think
> about it, but anyway, it shouldn't change anything.  Even with vanilla
> cpp(1) both produce the right thing, with or without __cplusplus defined,
> and both produce the identical thing (moins linenos/whitespace) in the
> C case.
> 
> Of course, both <uuid.h> and <sys/uuid.h> needed changed, as both
> define protos, and <sys/uuid.h> is included into <uuid.h>.

That's arguably bad, sys/uuid.h shouldn't have any !_KERNEL prototypes
in it.

Cheers,
Maxime

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message