From owner-cvs-src@FreeBSD.ORG  Tue Jan 25 09:53:36 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 272D016A4CF; Tue, 25 Jan 2005 09:53:36 +0000 (GMT)
Received: from critter.freebsd.dk (f170.freebsd.dk [212.242.86.170])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 5F27C43D1F; Tue, 25 Jan 2005 09:53:35 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id j0P9rX7M080082;
	Tue, 25 Jan 2005 10:53:33 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: Andrey Chernov <ache@nagual.pp.ru>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 25 Jan 2005 12:42:26 +0300."
             <20050125094226.GA28188@nagual.pp.ru> 
Date: Tue, 25 Jan 2005 10:53:33 +0100
Message-ID: <80081.1106646813@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: cvs-src@FreeBSD.ORG
cc: src-committers@FreeBSD.ORG
cc: cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/kern sys_generic.c 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Jan 2005 09:53:36 -0000

In message <20050125094226.GA28188@nagual.pp.ru>, Andrey Chernov writes:
>On Tue, Jan 25, 2005 at 09:15:32AM +0000, Poul-Henning Kamp wrote:
>>     sys/kern             sys_generic.c 
>>   Log:
>>   Previously a read of zero bytes got handled in devfs:vop_read() but I
>>   missed that when the vnode bypass was introduced.
>>   
>>   Deal with zero length transfers before we even get to fo_ops->fo_read().
>
>Please back it out. Zero bytes read may affect atime, now not.

No way.

That would be just as bogus as the fact that open(2) doesn't affect atime.

That is currently under discussion for reconsideration btw:

Today atime is not affected if you open and mmap a file.

Likewise I belive sendfile would not update atime either.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.