From owner-freebsd-ports@FreeBSD.ORG  Tue May  6 22:35:08 2003
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4CEBD37B404
	for <ports@freebsd.org>; Tue,  6 May 2003 22:35:08 -0700 (PDT)
Received: from web13509.mail.yahoo.com (web13509.mail.yahoo.com
	[216.136.173.13])
	by mx1.FreeBSD.org (Postfix) with SMTP id 114BB43FAF
	for <ports@freebsd.org>; Tue,  6 May 2003 22:35:07 -0700 (PDT)
	(envelope-from dyeske@yahoo.com)
Message-ID: <20030507053506.94163.qmail@web13509.mail.yahoo.com>
Received: from [68.114.30.244] by web13509.mail.yahoo.com via HTTP;
	Tue, 06 May 2003 22:35:06 PDT
Date: Tue, 6 May 2003 22:35:06 -0700 (PDT)
From: David Yeske <dyeske@yahoo.com>
To: kris@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
cc: ports@freebsd.org
cc: arved <arved@freebsd.org>
cc: Mario <lioux@freebsd.org>
Subject: mpeg4ip is not broken
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 07 May 2003 05:35:08 -0000

Mpeg4ip is not broken on stable.  I have fixed mpeg4ip on current
 
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/50233

I have a weird workaround that I don't think is addressing the problem.  For some reason I think
the value of `${SDL_CONFIG} --libs` is being parsed before it makes it into the Makefile during
the autoconf / libtool process.  This causes the -lc_r to be stripped away.

In a unpatched configuration the src/player/Makefile will have this block of text.  This is
missing the needed -lc_r

mp4player_LDADD = \
        -lm \
        libmp4player.la \
        libmp4syncbase.la \
        libmp4syncsdl.la \
        libmp4syncbase.la \
        libmp4playerutils.la \
        -lSDL-1.1 \
        /usr/local/lib/libSDLmain-1.1.a

In a patched configuration it will look like this

mp4player_LDADD = \
        -lm \
        libmp4player.la \
        libmp4syncbase.la \
        libmp4syncsdl.la \
        libmp4syncbase.la \
        libmp4playerutils.la \
        -L/usr/local/lib -Wl,-rpath,/usr/local/lib "-lc_r -lSDL-1.1" -lc_r \
        /usr/local/lib/libSDLmain-1.1.a

This entry for the port Makefile fixes it.  But there must be a better way?

.if ${OSVERSION} >= 500000
        @${REINPLACE_CMD} -E -e \
                's|-lSDL-1.1|"${PTHREAD_LIBS} -lSDL-1.1"|' \
                ${WRKSRC}/player/src/Makefile \
                ${WRKSRC}/util/yuv/Makefile \
                ${WRKSRC}/util/iptv/Makefile
.endif

__________________________________
Do you Yahoo!?
The New Yahoo! Search - Faster. Easier. Bingo.
http://search.yahoo.com