From owner-freebsd-fs  Thu Oct 30 17:11:58 1997
Return-Path: <owner-freebsd-fs>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id RAA26572
          for fs-outgoing; Thu, 30 Oct 1997 17:11:58 -0800 (PST)
          (envelope-from owner-freebsd-fs)
Received: from gatekeeper.tsc.tdk.com (root@gatekeeper.tsc.tdk.com [207.113.159.21])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id RAA26566
          for <freebsd-fs@FreeBSD.ORG>; Thu, 30 Oct 1997 17:11:54 -0800 (PST)
          (envelope-from gdonl@tsc.tdk.com)
Received: from sunrise.gv.tsc.tdk.com (root@sunrise.gv.tsc.tdk.com [192.168.241.191])
          by gatekeeper.tsc.tdk.com (8.8.4/8.8.4) with ESMTP
	  id RAA12839; Thu, 30 Oct 1997 17:11:26 -0800 (PST)
Received: from salsa.gv.tsc.tdk.com (salsa.gv.tsc.tdk.com [192.168.241.194])
	by sunrise.gv.tsc.tdk.com (8.8.5/8.8.5) with ESMTP id RAA06367;
	Thu, 30 Oct 1997 17:11:25 -0800 (PST)
Received: (from gdonl@localhost)
	by salsa.gv.tsc.tdk.com (8.8.5/8.8.5) id RAA02224;
	Thu, 30 Oct 1997 17:11:24 -0800 (PST)
From: Don Lewis <Don.Lewis@tsc.tdk.com>
Message-Id: <199710310111.RAA02224@salsa.gv.tsc.tdk.com>
Date: Thu, 30 Oct 1997 17:11:23 -0800
In-Reply-To: Wolfram Schneider <wosch@cs.tu-berlin.de>
       "Re: disabled symlinks" (Oct 31, 12:13am)
X-Mailer: Mail User's Shell (7.2.6 alpha(3) 7/19/95)
To: Wolfram Schneider <wosch@cs.tu-berlin.de>,
        Ollivier Robert <roberto@keltia.freenix.fr>
Subject: Re: disabled symlinks
Cc: freebsd-fs@FreeBSD.ORG
Sender: owner-freebsd-fs@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

On Oct 31, 12:13am, Wolfram Schneider wrote:
} Subject: Re: disabled symlinks
} Index: sys/kern/vfs_syscalls.c
} ===================================================================
} RCS file: /usr/cvs/src/sys/kern/vfs_syscalls.c,v
} retrieving revision 1.51.2.6
} diff -u -r1.51.2.6 vfs_syscalls.c
} --- vfs_syscalls.c	1997/10/23 18:04:55	1.51.2.6
} +++ vfs_syscalls.c	1997/10/30 22:24:47
} @@ -1326,8 +1328,10 @@
}  		return (error);
}  	vp = nd.ni_vp;
}  	error = vn_stat(vp, &sb, p);
} -	if (vp->v_type == VLNK)
} +	if (vp->v_type == VLNK && 
} +		(vp->v_mount->mnt_flag & MNT_NOSYMLINKFOLLOW) != 0)

This test looks backwards to me (it changes the behavior if the
new nosymlinkfollow option is not set).  I'm also not clear as
to why the behaviour even depends on the option.  Also, shouldn't
the same change be made to both lstat() and olstat()?

}  		sb.st_mode |= S_IFLNK | ACCESSPERMS;	/* 0777 */
} +
}  	vput(vp);
}  	if (error)
}  		return (error);

			---  Truck