From owner-freebsd-current@FreeBSD.ORG Tue Jun 20 21:24:11 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A3DD16A47C; Tue, 20 Jun 2006 21:24:11 +0000 (UTC) (envelope-from mnag@FreeBSD.org) Received: from corp.grupos.com.br (corp.grupos.com.br [200.193.29.43]) by mx1.FreeBSD.org (Postfix) with ESMTP id 35E7643D64; Tue, 20 Jun 2006 21:24:10 +0000 (GMT) (envelope-from mnag@FreeBSD.org) Received: from corp.grupos.com.br (corp.grupos.com.br [192.168.10.2]) by corp.grupos.com.br (Postfix) with ESMTP id E303E5CBE; Tue, 20 Jun 2006 18:24:07 -0300 (BRT) Received: from [192.168.10.10] (marcus.grupos.com.br [192.168.10.10]) by corp.grupos.com.br (Postfix) with ESMTP id B4BF45CBC; Tue, 20 Jun 2006 18:24:07 -0300 (BRT) Message-ID: <44986777.6070601@FreeBSD.org> Date: Tue, 20 Jun 2006 18:24:07 -0300 From: Marcus Alves Grando Organization: FreeBSD.org User-Agent: Thunderbird 1.5.0.4 (X11/20060605) MIME-Version: 1.0 To: John Baldwin References: <449015DE.6090407@fer.hr> <200606201002.07695.jhb@freebsd.org> <20060620230149.S43840@atlantis.atlantis.dp.ua> <200606201707.05938.jhb@freebsd.org> In-Reply-To: <200606201707.05938.jhb@freebsd.org> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Filtered: By ProxSMTP using Clamav and Bogofilter Cc: Adi Pircalabu , Hajimu UMEMOTO , kan@freebsd.org, Ivan Voras , freebsd-current@freebsd.org, Dmitry Pryanishnikov Subject: Re: Linux-flashplugin7 & rtld - RFC X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2006 21:24:11 -0000 John Baldwin wrote: > On Tuesday 20 June 2006 16:07, Dmitry Pryanishnikov wrote: >> Hello! >> >> On Tue, 20 Jun 2006, John Baldwin wrote: >>>>> This patch is somewhat redundant. Adding >>>>> >>>>> __weak_reference(dlsym, _dlsym); >>>>> >>>>> is enough. >>>> Indeed, this also works for me. It would be nice to see this trivial >>>> addition committed. >>> I agree. Do you have the __weak_reference() patch handy? >> Sure, here is the diff against HEAD: >> >> --- libexec/rtld-elf/rtld.c.orig Tue Mar 28 10:17:21 2006 >> +++ libexec/rtld-elf/rtld.c Tue Jun 20 22:35:17 2006 >> @@ -137,6 +137,8 @@ >> >> void r_debug_state(struct r_debug*, struct link_map*); >> >> +__weak_reference(dlsym, _dlsym); >> + >> /* >> * Data declarations. >> */ >> >> I'm not sure whether it's style(9)-compliant, it just works. > > Well, this patch was shot down. Would it be possible to have the > pluginwrapper provide the _dlsym weak reference itself? > I already try. That's not possible. I don't know why :/ but i think that's because something with linux emulation/load shared libraries. Regards -- Marcus Alves Grando marcus(at)corp.grupos.com.br | Grupos Internet S/A mnag(at)FreeBSD.org | FreeBSD.org