Date: Mon, 5 Oct 2009 22:40:44 GMT From: Sofian Brabez <sbrabez@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/139369: [patch] www/mplayer-plugin: fix firefox freeze and USE_GECKO Message-ID: <200910052240.n95Mei4r011394@www.freebsd.org> Resent-Message-ID: <200910052250.n95Mo1RH096720@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 139369
>Category: ports
>Synopsis: [patch] www/mplayer-plugin: fix firefox freeze and USE_GECKO
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Oct 05 22:50:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Sofian Brabez
>Release: FreeBSD 7.2-STABLE i386
>Organization:
>Environment:
FreeBSD freebsd.ifr.lan 7.2-STABLE FreeBSD 7.2-STABLE #0: Thu Jul 2 23:42:18 CEST 2009 root@freebsd.ifr.lan:/usr/obj/usr/src/sys/FREEBSD i386
>Description:
- Add patch files/patch-plugin_threads_cpp.diff to fix firefox zombie and freeze obtained from OpenBSD port
- Fix USE_GECKO to compile it with new firefox versions obtained from miwi@
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
diff -urN mplayer-plugin.orig/Makefile mplayer-plugin/Makefile
--- mplayer-plugin.orig/Makefile 2009-10-06 00:16:01.000000000 +0200
+++ mplayer-plugin/Makefile 2009-10-06 00:12:34.000000000 +0200
@@ -18,7 +18,7 @@
USE_GETTEXT= yes
USE_GMAKE= yes
-USE_GECKO= firefox mozilla seamonkey libxul
+USE_GECKO= libxul
USE_WEBPLUGINS= gecko*
WEBPLUGINS_FILES=mplayerplug-in.so mplayerplug-in.xpt mplayerplug-in-wmp.so \
mplayerplug-in-qt.so mplayerplug-in-rm.so \
diff -urN mplayer-plugin.orig/files/patch-plugin_threads_cpp.diff mplayer-plugin/files/patch-plugin_threads_cpp.diff
--- mplayer-plugin.orig/files/patch-plugin_threads_cpp.diff 1970-01-01 01:00:00.000000000 +0100
+++ mplayer-plugin/files/patch-plugin_threads_cpp.diff 2009-10-06 00:12:34.000000000 +0200
@@ -0,0 +1,14 @@
+--- Source/plugin-threads.cpp.orig 2008-06-12 23:38:37.000000000 -0400
++++ Source/plugin-threads.cpp 2009-10-01 05:04:31.000000000 -0400
+@@ -14,8 +14,11 @@
+
+ static void sig_child(int signo)
+ {
+- // Not used, so commented out
+- // wait(NULL);
++ pid_t pid;
++ int status;
++
++ pid = wait(&status);
++ return;
+ }
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200910052240.n95Mei4r011394>