From owner-svn-src-all@freebsd.org Thu Jan 14 16:51:07 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 85C49A816B3 for ; Thu, 14 Jan 2016 16:51:07 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-wm0-x22f.google.com (mail-wm0-x22f.google.com [IPv6:2a00:1450:400c:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3F5521010 for ; Thu, 14 Jan 2016 16:51:07 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by mail-wm0-x22f.google.com with SMTP id l65so352842891wmf.1 for ; Thu, 14 Jan 2016 08:51:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=from:subject:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=qc/6cO+nvQ2gIKQnlr3ErMRRD+NSuQ9mS9O5tw8wsis=; b=D/M/IXlBmuZx4HxBZvT/oMytZ/yA8WXR23wDFomgs9DBtQX2RFtszqq8Km0bZV+qem O++SV9nRf3AyJt+CNKvAtY5vlSsnYW6AbF9g9OusFRLvX6i0V0ktoILQbRRY9B1PMPLM cA0Feg24/Pdyl3O5TbNF18wU13xWeXYi0mbyjACLgBIVxEgUtBOFY3ZCEEqtA6XVviyd 76hPsFPjKrgaa8ufWgghTIvvJkaeMLVgrwtrc8EsLoHbZI2wUuDjHCFurq5U8t+abYkF 4lM0wZe3YKAnIg7fdG+bh4l5LC1tJ1CYSblsKUiER5kPksBgh0/rRXiIGuFHfh4TmH5d 8HfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=qc/6cO+nvQ2gIKQnlr3ErMRRD+NSuQ9mS9O5tw8wsis=; b=GtMXwHExelD1k4pKcxjqqbEdLRPGeyd9fWsaeKn6HeGn75zJrcjluMILUuVw2nEnvr QGodbY9v30xCzCv85F3p0bvQ0vfdge3mHEmEQHjQsJ4oFKZKK9nmgliNY8s+EDdRE5Y/ dynIHx+mbUxjJmxT07WGizeVMBIjH80KKGO/rA3A8xxxkqeubvySZO/2sgXpZkQwbvrK XrHFLKuPphxQ7F9+kJ062NaUnRNCjOYnNOg9rNdKUQlW91ojdd3StgZE9J8EMHnJXOdq vDsJFFPBhVcTfdb64Piq0WJhxpGRpi9PKVoWKfujfhn/4IfYbsLcgmvCpfvPjVZxj99X DJwg== X-Gm-Message-State: ALoCoQkBa4WizMqusUZGbac5sIHskZw6kyLmafkfLeQtiZnz/j2NDYAJIM0OTeGreZBKjntS6jNyxJ/HrwTAgWKraIb6z2c0JQ== X-Received: by 10.194.184.210 with SMTP id ew18mr5068171wjc.79.1452790265248; Thu, 14 Jan 2016 08:51:05 -0800 (PST) Received: from [10.10.1.58] (liv3d.labs.multiplay.co.uk. [82.69.141.171]) by smtp.gmail.com with ESMTPSA id lh1sm6836149wjb.20.2016.01.14.08.51.03 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 14 Jan 2016 08:51:03 -0800 (PST) From: Steven Hartland X-Google-Original-From: Steven Hartland Subject: Re: svn commit: r293903 - in head/sys/boot: arm/uboot efi/fdt efi/libefi To: John Baldwin , NGie Cooper References: <201601140922.u0E9M1rV025146@repo.freebsd.org> <8690606.xvPx6EyIfQ@ralph.baldwin.cx> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <5697D20A.9050309@freebsd.org> Date: Thu, 14 Jan 2016 16:51:22 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <8690606.xvPx6EyIfQ@ralph.baldwin.cx> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2016 16:51:07 -0000 On 14/01/2016 15:55, John Baldwin wrote: > On Thursday, January 14, 2016 01:27:51 AM NGie Cooper wrote: >>> On Jan 14, 2016, at 01:22, Steven Hartland wrote: >>> >>> Author: smh >>> Date: Thu Jan 14 09:22:01 2016 >>> New Revision: 293903 >>> URL: https://svnweb.freebsd.org/changeset/base/293903 >>> >>> Log: >>> Fix GCC warnings causing build failure after r293724 >>> >>> Disable some compiler warnings for GCC (non-standard compiler) fixing >>> build failures introduced by r293724, which enabled WARNS in the EFI boot >>> code, when compiling with none standard compiler (GCC). >> Disabling warnings is wrong. Here’s how arm could be fixed: >> >> $ svn diff sys/boot/ >> Index: sys/boot/common/bootstrap.h >> =================================================================== >> --- sys/boot/common/bootstrap.h (revision 293877) >> +++ sys/boot/common/bootstrap.h (working copy) >> @@ -32,6 +32,7 @@ >> #include >> #include >> #include >> +#include >> >> /* >> * Generic device specifier; architecture-dependant >> @@ -332,12 +333,8 @@ >> extern struct arch_switch archsw; >> >> /* This must be provided by the MD code, but should it be in the archsw? */ >> -void delay(int delay); >> - > The comment seems to be related to delay() so it should perhaps go as well? > delay is actually provided by libefi but nothing else in sys/boot, so I cant see why this was ever needed, possibly a hang over?