From owner-freebsd-net@freebsd.org  Thu Jul 23 11:58:22 2020
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 284A737C1E3
 for <freebsd-net@mailman.nyi.freebsd.org>;
 Thu, 23 Jul 2020 11:58:22 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4BC9p60GzJz4SjB
 for <freebsd-net@freebsd.org>; Thu, 23 Jul 2020 11:58:22 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com
 [209.85.219.51])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 (Authenticated sender: kevans)
 by smtp.freebsd.org (Postfix) with ESMTPSA id D979B1A017
 for <freebsd-net@freebsd.org>; Thu, 23 Jul 2020 11:58:21 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: by mail-qv1-f51.google.com with SMTP id el4so2405798qvb.13
 for <freebsd-net@freebsd.org>; Thu, 23 Jul 2020 04:58:21 -0700 (PDT)
X-Gm-Message-State: AOAM530hMjwX5kkn3v8RRc+xstewGzRG6xW6dQmaCJYrGMRYuzssN8qS
 3U8C/FXcTQxGgVrrYGTAIcJwpAsMiUWvWW13NqE=
X-Google-Smtp-Source: ABdhPJzzVGNDgvuAUC0Zxmwq/wid3JChK2LMuhC+VYSjgn/NtoGyinBRgRIfdnFB6U32luSv4SmGd5fIhEyZ5+P5s+Y=
X-Received: by 2002:a0c:83e6:: with SMTP id k93mr4297840qva.112.1595505501401; 
 Thu, 23 Jul 2020 04:58:21 -0700 (PDT)
MIME-Version: 1.0
References: <CACNAnaF0kj4q688DNt+HKCSdindn9YBYW2aKOiu0cWQsrShUgA@mail.gmail.com>
 <fc2535e6-82a1-34cf-c204-75fcfda51f09@selasky.org>
In-Reply-To: <fc2535e6-82a1-34cf-c204-75fcfda51f09@selasky.org>
From: Kyle Evans <kevans@freebsd.org>
Date: Thu, 23 Jul 2020 06:58:10 -0500
X-Gmail-Original-Message-ID: <CACNAnaH8oCMP385E1wWymoNk1tyKS-fFkvJt39eqRrfQMhgpyQ@mail.gmail.com>
Message-ID: <CACNAnaH8oCMP385E1wWymoNk1tyKS-fFkvJt39eqRrfQMhgpyQ@mail.gmail.com>
Subject: Re: Abandoning ifnet work
To: Hans Petter Selasky <hps@selasky.org>
Cc: freebsd-net <freebsd-net@freebsd.org>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Jul 2020 11:58:22 -0000

On Thu, Jul 23, 2020 at 3:38 AM Hans Petter Selasky <hps@selasky.org> wrote:
>
> On 2020-07-23 05:45, Kyle Evans wrote:
> > abandoning because the review process for this area is simply not
>
> Are you looking for this:
>
> https://reviews.freebsd.org/D24914
>

No, not at all. The race I was reliably hitting is more like:

1. epair sets its vnet 'to the other half' in epair_clone_destroy
2. destroys that
3. goes to CURVNET_RESTORE(), but the vnet we were in has been
destroyed out from underneath us and we die in a fire trying to check
saved_vnet->vnet_magic_n

Thanks,

Kyle Evans