From owner-freebsd-net@FreeBSD.ORG  Sun Mar 30 11:28:16 2003
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EEA8A37B401
	for <net@freebsd.org>; Sun, 30 Mar 2003 11:28:16 -0800 (PST)
Received: from smtp-relay.omnis.com (smtp-relay.omnis.com [216.239.128.27])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5D3F243FB1
	for <net@freebsd.org>; Sun, 30 Mar 2003 11:28:16 -0800 (PST)
	(envelope-from wes@softweyr.com)
Received: from softweyr.homeunix.net (66-91-236-204.san.rr.com
	[66.91.236.204])	by smtp-relay.omnis.com (Postfix) with ESMTP
	id A8BBE42D30; Sun, 30 Mar 2003 11:28:10 -0800 (PST)
From: Wes Peters <wes@softweyr.com>
Organization: Softweyr
To: "M. Warner Losh" <imp@bsdimp.com>, net@freebsd.org
Date: Sun, 30 Mar 2003 11:28:09 -0800
User-Agent: KMail/1.5
References: <20030329.195108.133248709.imp@bsdimp.com>
In-Reply-To: <20030329.195108.133248709.imp@bsdimp.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200303301128.09717.wes@softweyr.com>
Subject: Re: ifconfig question
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Mar 2003 19:28:20 -0000

On Saturday 29 March 2003 18:51, M. Warner Losh wrote:
> The code that prints out the keys for the 802.11 wireless stuff has
> the following it it:
>
> void
> ieee80211_status (int s, struct rt_addrinfo *info __unused)
> {
> ...
> 			if (ireq.i_len == 0 || ireq.i_len > 13)
> 				continue;
> ...
> }
>
> Should that check really be there?  Newer wep does 256bits....  Not
> that the rest of the code supports that, but I was just curious.

Only if the spec says those are the only valid ranges.  Then we have to 
keep up to date with changes in the spec, too.  Either some simple sanity 
checks or checking for truly valid lengths -- 0, 40 bits, 128 bits -- 
makes even better sense.

> Second, should ifconfig report the wep key if run as root?  wicontrol
> does if it is run as root, for example.  Any objections for fixing
> this?

That would be convenient.

-- 

        Where am I, and what am I doing in this handbasket?

Wes Peters                                               wes@softweyr.com