From owner-svn-ports-head@freebsd.org  Fri Jul  5 21:25:40 2019
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 25C0815D4FFE;
 Fri,  5 Jul 2019 21:25:40 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id BDBB88A809;
 Fri,  5 Jul 2019 21:25:39 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id ADC5915430; Fri,  5 Jul 2019 21:25:39 +0000 (UTC)
Date: Fri, 5 Jul 2019 21:25:39 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Jan Beich <jbeich@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r505908 - in head/sysutils: . netevent netevent/files
Message-ID: <20190705212539.GA21664@FreeBSD.org>
References: <201907051908.x65J88nq064712@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201907051908.x65J88nq064712@repo.freebsd.org>
User-Agent: Mutt/1.11.4 (2019-03-13)
X-Rspamd-Queue-Id: BDBB88A809
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.90 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-0.999,0];
 NEURAL_HAM_SHORT(-0.90)[-0.898,0];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Jul 2019 21:25:40 -0000

On Fri, Jul 05, 2019 at 07:08:08PM +0000, Jan Beich wrote:
> New Revision: 505908
> URL: https://svnweb.freebsd.org/changeset/ports/505908
> 
> Log:
>   sysutils/netevent: add new port

It would be nice to briefly describe it, even in the commit log.

> +COMMENT=	Tool for sharing uinput devices with other machines

What's "uinput"?  'U' and 'I' letters are adjacent on my keyboard, is
this a typo?

> +OPTIONS_SUB=		MANPAGES

That's the same as OPTIONS_SUB=yes.  I also like the idea of putting
specific options on the OPTIONS_SUB list, but someone on portmgr@ had
told me they won't do this.

> Added: head/sysutils/netevent/pkg-plist
> @@ -0,0 +1,3 @@
> +bin/netevent
> +%%MANPAGES%%man/man1/netevent.1.gz
> +%%PORTEXAMPLES%%%%EXAMPLESDIR%%/simple.ne2

Three-line pkg-plist is a good candidate for PLIST_FILES/PORTDOCS/
PORTEXAMPLES.

./danfe