From owner-freebsd-net@FreeBSD.ORG Mon May 11 11:38:32 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 56D695D9 for ; Mon, 11 May 2015 11:38:32 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CAA1514E2 for ; Mon, 11 May 2015 11:38:31 +0000 (UTC) Received: from moby.local ([88.66.149.6]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MbrR4-1YbtLf2SzW-00JJkM for ; Mon, 11 May 2015 13:38:29 +0200 Message-ID: <55509492.7070308@gmx.com> Date: Mon, 11 May 2015 13:37:54 +0200 From: Nikos Vassiliadis User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: FreeBSD Net Subject: if_bridge panic plus fix Content-Type: multipart/mixed; boundary="------------080900010109010603030604" X-Provags-ID: V03:K0:bP9D9tPuNHfyoHt3fuUghJwwlWPJMzpjhg9/QnX1RLF7a0sDFR2 dU8e85uXAPKwTYEyjg9IrJQ/Tf8eRt4LqalRjKskxwWhUlXDqCk4jRmgA8IMW8ljyJinzSc gFjYC4Xj8eYn8vwNHrnfSusdpJ6mRWjQ3F0c8rwAfYN2vqIGC46p04guGjvJU5XTzpmPck+ Rke1kaMbNRzXT2K3V+g2A== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 May 2015 11:38:32 -0000 This is a multi-part message in MIME format. --------------080900010109010603030604 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Small fix for if_bridge.c. bridge_state_change() is called from taskqueue and curvnet is not set. Patch attached. The panic: > #6 0xffffffff80d9a8c9 in trap_fatal (frame=0xfffffe01a5a998b0, eva=) at /usr/src/sys/amd64/amd64/trap.c:854 > #7 0xffffffff80d9ab5e in trap_pfault (frame=0xfffffe01a5a998b0, usermode=) at /usr/src/sys/amd64/amd64/trap.c:676 > #8 0xffffffff80d9a215 in trap (frame=0xfffffe01a5a998b0) at /usr/src/sys/amd64/amd64/trap.c:426 > #9 0xffffffff80d7a8c2 in calltrap () at /usr/src/sys/amd64/amd64/exception.S:235 > #10 0xffffffff81e1b767 in bridge_state_change (ifp=0x1, state=Unhandled dwarf expression opcode 0x93 > ) at /usr/src/sys/modules/if_bridge/../../net/if_bridge.c:3068 > #11 0xffffffff809beaa0 in taskqueue_run_locked (queue=0x20) at /usr/src/sys/kern/subr_taskqueue.c:431 > #12 0xffffffff809be96a in taskqueue_run (queue=0xfffff80005192d00) at /usr/src/sys/kern/subr_taskqueue.c:450 > #13 0xffffffff8093ac61 in intr_event_execute_handlers (p=, ie=0xfffff80005171200) at /usr/src/sys/kern/kern_intr.c:1241 > #14 0xffffffff8093b63c in ithread_loop (arg=0xfffff8000517af40) at /usr/src/sys/kern/kern_intr.c:1254 Thanks for reviewing, Nikos --------------080900010109010603030604 Content-Type: text/plain; charset=us-ascii; name="if_bridge.c.diff.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="if_bridge.c.diff.txt" SW5kZXg6IHN5cy9uZXQvaWZfYnJpZGdlLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL25ldC9p Zl9icmlkZ2UuYwkocmV2aXNpb24gMjgyNjUxKQorKysgc3lzL25ldC9pZl9icmlkZ2UuYwko d29ya2luZyBjb3B5KQpAQCAtMzA2NSw5ICszMDY1LDExIEBAIGJyaWRnZV9zdGF0ZV9jaGFu Z2Uoc3RydWN0IGlmbmV0ICppZnAsIGludCBzdGF0ZSkKIAkJImRpc2NhcmRpbmciCiAJfTsK IAorCUNVUlZORVRfU0VUKGlmcC0+aWZfdm5ldCk7CiAJaWYgKFZfbG9nX3N0cCkKIAkJbG9n KExPR19OT1RJQ0UsICIlczogc3RhdGUgY2hhbmdlZCB0byAlcyBvbiAlc1xuIiwKIAkJICAg IHNjLT5zY19pZnAtPmlmX3huYW1lLCBzdHBzdGF0ZXNbc3RhdGVdLCBpZnAtPmlmX3huYW1l KTsKKwlDVVJWTkVUX1JFU1RPUkUoKTsKIH0KIAogLyoK --------------080900010109010603030604--