From owner-svn-src-head@FreeBSD.ORG  Tue Jun  7 05:42:31 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 008AD106564A;
	Tue,  7 Jun 2011 05:42:31 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail07.syd.optusnet.com.au (mail07.syd.optusnet.com.au
	[211.29.132.188])
	by mx1.freebsd.org (Postfix) with ESMTP id 74DF78FC0A;
	Tue,  7 Jun 2011 05:42:30 +0000 (UTC)
Received: from c122-106-165-191.carlnfd1.nsw.optusnet.com.au
	(c122-106-165-191.carlnfd1.nsw.optusnet.com.au [122.106.165.191])
	by mail07.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	p575gCed016377
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 7 Jun 2011 15:42:28 +1000
Date: Tue, 7 Jun 2011 15:42:12 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Pan Tsu <inyaoo@gmail.com>
In-Reply-To: <86y61ehmnx.fsf@gmail.com>
Message-ID: <20110607153624.B975@besplex.bde.org>
References: <201106061255.p56Ct3qN031795__3239.16238635338$1307364936$gmane$org@svn.freebsd.org>
	<86y61ehmnx.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Robert Watson <rwatson@freebsd.org>
Subject: Re: svn commit: r222748 - in head/sys: conf netinet netinet/ipfw
 netinet6
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Jun 2011 05:42:31 -0000

On Mon, 6 Jun 2011, Pan Tsu wrote:

> Robert Watson <rwatson@FreeBSD.org> writes:
>
>> Author: rwatson
>> Date: Mon Jun  6 12:55:02 2011
>> New Revision: 222748
>> URL: http://svn.freebsd.org/changeset/base/222748
>>
>> Log:
> [...]
>>   Connection group support is enabled by compiling "options PCBGROUP"
>>   into your kernel configuration; for the time being, this is an
>>   experimental feature, and hence is not enabled by default.
>
> Doesn't build with "nooption WITNESS" as in6_pcbgroup.c relies on
> <sys/mbuf.h> including <sys/lock.h> unconditionally, e.g.
>
>  $ make -s buildkernel
>  [...]
>  --------------------------------------------------------------
>  >>> stage 3.1: making dependencies
>  --------------------------------------------------------------
>  In file included from /usr/src/sys/netinet/in_pcb.h:47,
>                   from /usr/src/sys/netinet6/in6_pcbgroup.c:40:
>  /usr/src/sys/sys/rwlock.h:152:2: error: #error LOCK_DEBUG not defined, include <sys/lock.h> before <sys/rwlock.h>
>  mkdep: compile failed
>  *** Error code 1

<sys/mbuf.h> was disgustingly polluted even before it included <sys/lock.h>.

Bruce