From owner-svn-src-all@freebsd.org Mon Feb 8 22:50:46 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DECD6AA26CB; Mon, 8 Feb 2016 22:50:46 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (glebi.us [96.95.210.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id CA48F10F1; Mon, 8 Feb 2016 22:50:46 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id u18MoeIT093703 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 8 Feb 2016 14:50:40 -0800 (PST) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id u18ModRP093702; Mon, 8 Feb 2016 14:50:39 -0800 (PST) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 8 Feb 2016 14:50:39 -0800 From: Gleb Smirnoff To: John Baldwin Cc: Bryan Drewery , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r295226 - head/lib/libmemstat Message-ID: <20160208225039.GZ72286@FreeBSD.org> References: <201602040023.u140NL0i052392@repo.freebsd.org> <56B29E36.8000900@FreeBSD.org> <20160204170603.GF65294@FreeBSD.org> <12103176.kVCUAMSdl5@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12103176.kVCUAMSdl5@ralph.baldwin.cx> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2016 22:50:47 -0000 On Mon, Feb 08, 2016 at 01:21:18PM -0800, John Baldwin wrote: J> On Thursday, February 04, 2016 09:06:03 AM Gleb Smirnoff wrote: J> > On Wed, Feb 03, 2016 at 04:41:26PM -0800, Bryan Drewery wrote: J> > B> On 2/3/2016 4:23 PM, Gleb Smirnoff wrote: J> > B> > Author: glebius J> > B> > Date: Thu Feb 4 00:23:21 2016 J> > B> > New Revision: 295226 J> > B> > URL: https://svnweb.freebsd.org/changeset/base/295226 J> > B> > J> > B> > Log: J> > B> > Fix build. J> > B> > J> > B> > Modified: J> > B> > head/lib/libmemstat/memstat_uma.c J> > B> > J> > B> > Modified: head/lib/libmemstat/memstat_uma.c J> > B> > ============================================================================== J> > B> > --- head/lib/libmemstat/memstat_uma.c Wed Feb 3 23:41:58 2016 (r295225) J> > B> > +++ head/lib/libmemstat/memstat_uma.c Thu Feb 4 00:23:21 2016 (r295226) J> > B> > @@ -29,6 +29,7 @@ J> > B> > #include J> > B> > #include J> > B> > #include J> > B> > +#include J> > B> > J> > B> > #include J> > B> > #include J> > B> > J> > B> J> > B> Shouldn't uma_int.h forward declare or include _task.h for struct task? J> > J> > Forward declaration won't work, since structure is included, not pointed at. J> > I'm reluctant with adding includes into includes. J> J> The sys/_foo.h headers are specifically designed so they can be used as nested J> includes while (hopefully) introducing minimal pollution. If you are embedding J> struct task in a structure, use a nested include of . That is J> why exists as a separate header from . Thanks, John. Will try to fixup that now. -- Totus tuus, Glebius.