From owner-cvs-all@FreeBSD.ORG Mon Aug 20 16:40:57 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1F51E16A417; Mon, 20 Aug 2007 16:40:57 +0000 (UTC) (envelope-from rpaulo@fnop.net) Received: from core.fnop.net (mx.fnop.net [82.102.11.82]) by mx1.freebsd.org (Postfix) with ESMTP id 8630613C49D; Mon, 20 Aug 2007 16:40:56 +0000 (UTC) (envelope-from rpaulo@fnop.net) Received: from core.fnop.net (mx.fnop.net [82.102.11.82]) by core.fnop.net (Postfix) with ESMTP id 98CA2691061; Mon, 20 Aug 2007 17:44:32 +0100 (WEST) Received: by core.fnop.net (Postfix, from userid 1015) id 53B3669106F; Mon, 20 Aug 2007 17:44:32 +0100 (WEST) X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on core.fnop.net X-Spam-Level: * X-Spam-Status: No, score=1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DSBL, RCVD_IN_SORBS_DUL autolearn=no version=3.1.7 Received: from epsilon.local (unknown [83.144.141.37]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by core.fnop.net (Postfix) with ESMTP id CB1C5691061; Mon, 20 Aug 2007 17:44:28 +0100 (WEST) Message-ID: <46C9C413.5020102@fnop.net> Date: Mon, 20 Aug 2007 17:40:51 +0100 From: Rui Paulo User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: Olivier Houchard References: <200708201533.l7KFXNn1095584@repoman.freebsd.org> In-Reply-To: <200708201533.l7KFXNn1095584@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/gnu/fs/xfs/FreeBSD xfs_mountops.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 16:40:57 -0000 Olivier Houchard wrote: > cognet 2007-08-20 15:33:23 UTC > > FreeBSD src repository > > Modified files: > sys/gnu/fs/xfs/FreeBSD xfs_mountops.c > Log: > Some times ago, vfs_getopts() was changed, so that it would set error to > ENOENT if the option wasn't provided, instead of setting it to 0. > xfs however didn't catch up on this, so it assumed something went bad if > vfs_getopts() sets the error to non-zero, and just returns the error. > Unbreak xfs mount by just ignoring the error if vfs_getopts() sets the > error to ENOENT, as we should have sane defaults. > > Reviewed by: kan > Approved by: re (rwatson) > Tested by: rpaulo Thanks! -- Rui Paulo