Date: Sat, 18 Sep 2004 11:02:27 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Giorgos Keramidas <keramida@freebsd.org> Cc: gerarra@tin.it Subject: Re: FreeBSD Kernel buffer overflow Message-ID: <20040918090227.GX30151@darkness.comp.waw.pl> In-Reply-To: <20040917093712.GB94990@orion.daedalusnetworks.priv> References: <4146316C00007833@ims3a.cp.tin.it> <20040917093712.GB94990@orion.daedalusnetworks.priv>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Fri, Sep 17, 2004 at 12:37:12PM +0300, Giorgos Keramidas wrote:
+> % +#ifdef INVARIANTS
+> % + KASSERT(0 <= narg && narg <= 8, ("invalid number of syscall args"));
+> % +#endif
Maybe:
KASSERT(0 <= narg && narg <= sizeof(args) / sizeof(args[0]),
("invalid number of syscall args"));
So if we decide to increase/decrease it someday, we don't have to remember
about this KASSERT().
--
Pawel Jakub Dawidek http://www.FreeBSD.org
pjd@FreeBSD.org http://garage.freebsd.pl
FreeBSD committer Am I Evil? Yes, I Am!
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFBS/mjForvXbEpPzQRAuCYAJ4hISL5xYMiDagPT4RVMBTqiif8ngCg5nhz
Wu+K33ypmpSkYevUksLNXCQ=
=1cXj
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040918090227.GX30151>