From owner-freebsd-current@FreeBSD.ORG  Wed Aug  5 14:18:39 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8B25B1065674;
	Wed,  5 Aug 2009 14:18:39 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe02.swip.net [212.247.154.33])
	by mx1.freebsd.org (Postfix) with ESMTP id B3E658FC0A;
	Wed,  5 Aug 2009 14:18:38 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.0 c=1 a=1oMw4IlqKsAA:10
	a=MnI1ikcADjEx7bvsp0jZvQ==:17 a=8kQB0OdkAAAA:8 a=mK_AVkanAAAA:8
	a=6I5d2MoRAAAA:8 a=b1R08Nv5_apd6zTO7TQA:9
	a=nhatX0-YMK4GQ6Ob3rYA:7 a=UyDoTLh_JaLBb6Oqm3PzvbvJwAcA:4
	a=9aOQ2cSd83gA:10 a=9xyTavCNlvEA:10
Received: from [188.126.201.140] (account mc467741@c2i.net HELO
	laptop.adsl.tele2.no)
	by mailfe02.swip.net (CommuniGate Pro SMTP 5.2.13)
	with ESMTPA id 1300632731; Wed, 05 Aug 2009 16:18:37 +0200
From: Hans Petter Selasky <hselasky@c2i.net>
To: freebsd-current@freebsd.org
Date: Wed, 5 Aug 2009 16:18:36 +0200
User-Agent: KMail/1.11.4 (FreeBSD/8.0-BETA2; KDE/4.2.4; i386; ; )
References: <90a5caac0908050258w1ea85736sac0b66ae5998e7de@mail.gmail.com>
	<200908051603.35169.hselasky@c2i.net>
	<3bbf2fe10908050713r79066277hd8822161b78222f@mail.gmail.com>
In-Reply-To: <3bbf2fe10908050713r79066277hd8822161b78222f@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200908051618.37902.hselasky@c2i.net>
Cc: Attilio Rao <attilio@freebsd.org>, Ed Schouten <ed@80386.nl>,
	Robert Watson <rwatson@freebsd.org>,
	Lucius Windschuh <lwindschuh@googlemail.com>
Subject: Re: uaudio attach panic: Giant not locked
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Aug 2009 14:18:39 -0000

On Wednesday 05 August 2009 16:13:31 Attilio Rao wrote:
> 2009/8/5 Hans Petter Selasky <hselasky@c2i.net>:
> > On Wednesday 05 August 2009 13:43:11 Robert Watson wrote:
> >> On Wed, 5 Aug 2009, Ed Schouten wrote:
> >> > * Lucius Windschuh <lwindschuh@googlemail.com> wrote:
> >> >> So I updated my machine to CURRENT r196062 and use a USB audio
> >> >> converter. Attaching it to the machine leads to a kernel panic:
> >> >>
> >> >> <snip>
> >> >
> >> > I suspect this has something to do with the Newbus locking, which
> >> > causes some pieces of code to run without Giant held, while they
> >> > previously did.
> >>
> >> There's a patch in the re@ queue to re-add Giant around newbus
> >> attachment, per John Baldwin's request.  However, committing that patch
> >> is stalled while issues with the svn->cvs export of the new RELENG_8
> >> branch are resolved.  I expect to see the patch go into the tree RSN.
> >
> > Try this patch:
> >
> > http://perforce.freebsd.org/chv.cgi?CH=167030
>
> Hans,
> I recall of a similar problem in ukbd. I resolved it by acquiring
> Giant earlier in  ukbd_attach(), but probabilly I could just bring it
> down and pass a NULL pointer to usbd_do_transfer(), right?

Yes, correct.

I've changed the Giant mutex to a NULL one in USB P4. Maybe you can fix the 
rest?

http://perforce.freebsd.org/chv.cgi?CH=167032

--HPS