Date: Wed, 5 Aug 2009 16:18:36 +0200 From: Hans Petter Selasky <hselasky@c2i.net> To: freebsd-current@freebsd.org Cc: Attilio Rao <attilio@freebsd.org>, Ed Schouten <ed@80386.nl>, Robert Watson <rwatson@freebsd.org>, Lucius Windschuh <lwindschuh@googlemail.com> Subject: Re: uaudio attach panic: Giant not locked Message-ID: <200908051618.37902.hselasky@c2i.net> In-Reply-To: <3bbf2fe10908050713r79066277hd8822161b78222f@mail.gmail.com> References: <90a5caac0908050258w1ea85736sac0b66ae5998e7de@mail.gmail.com> <200908051603.35169.hselasky@c2i.net> <3bbf2fe10908050713r79066277hd8822161b78222f@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 05 August 2009 16:13:31 Attilio Rao wrote: > 2009/8/5 Hans Petter Selasky <hselasky@c2i.net>: > > On Wednesday 05 August 2009 13:43:11 Robert Watson wrote: > >> On Wed, 5 Aug 2009, Ed Schouten wrote: > >> > * Lucius Windschuh <lwindschuh@googlemail.com> wrote: > >> >> So I updated my machine to CURRENT r196062 and use a USB audio > >> >> converter. Attaching it to the machine leads to a kernel panic: > >> >> > >> >> <snip> > >> > > >> > I suspect this has something to do with the Newbus locking, which > >> > causes some pieces of code to run without Giant held, while they > >> > previously did. > >> > >> There's a patch in the re@ queue to re-add Giant around newbus > >> attachment, per John Baldwin's request. However, committing that patch > >> is stalled while issues with the svn->cvs export of the new RELENG_8 > >> branch are resolved. I expect to see the patch go into the tree RSN. > > > > Try this patch: > > > > http://perforce.freebsd.org/chv.cgi?CH=167030 > > Hans, > I recall of a similar problem in ukbd. I resolved it by acquiring > Giant earlier in ukbd_attach(), but probabilly I could just bring it > down and pass a NULL pointer to usbd_do_transfer(), right? Yes, correct. I've changed the Giant mutex to a NULL one in USB P4. Maybe you can fix the rest? http://perforce.freebsd.org/chv.cgi?CH=167032 --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200908051618.37902.hselasky>