From owner-freebsd-python@FreeBSD.ORG  Mon Nov 15 18:30:15 2010
Return-Path: <owner-freebsd-python@FreeBSD.ORG>
Delivered-To: freebsd-python@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 911B91065670
	for <freebsd-python@hub.freebsd.org>;
	Mon, 15 Nov 2010 18:30:15 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 64DF08FC15
	for <freebsd-python@hub.freebsd.org>;
	Mon, 15 Nov 2010 18:30:15 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oAFIUFqJ047949
	for <freebsd-python@freefall.freebsd.org>; Mon, 15 Nov 2010 18:30:15 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oAFIUFPK047946;
	Mon, 15 Nov 2010 18:30:15 GMT (envelope-from gnats)
Date: Mon, 15 Nov 2010 18:30:15 GMT
Message-Id: <201011151830.oAFIUFPK047946@freefall.freebsd.org>
To: freebsd-python@FreeBSD.org
From: John Hein <jhein@symmetricom.com>
Cc: 
Subject: Re: ports/152224: [patch] fix installed permissions for
	?lang/python27
X-BeenThere: freebsd-python@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: John Hein <jhein@symmetricom.com>
List-Id: FreeBSD-specific Python issues <freebsd-python.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-python>, 
	<mailto:freebsd-python-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-python>
List-Post: <mailto:freebsd-python@freebsd.org>
List-Help: <mailto:freebsd-python-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-python>,
	<mailto:freebsd-python-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Nov 2010 18:30:15 -0000

The following reply was made to PR ports/152224; it has been noted by GNATS.

From: John Hein <jhein@symmetricom.com>
To: Oliver Fromme <olli@lurza.secnetix.de>
Cc: Anonymous <swell.k@gmail.com>,
    python@FreeBSD.org,
    bug-followup@FreeBSD.org
Subject: Re: ports/152224: [patch] fix installed permissions for ?lang/python27
Date: Mon, 15 Nov 2010 11:21:06 -0700

 --9oaHwTfnCu
 Content-Type: text/plain; charset=us-ascii
 Content-Description: message body text
 Content-Transfer-Encoding: 7bit
 
 Oliver Fromme wrote at 18:35 +0100 on Nov 15, 2010:
  > Anonymous <swell.k@gmail.com> wrote:
  >  > John Hein <jhein@symmetricom.com> writes:
  >  > > +post-extract:
  >  > > +# The distribution tarball for python 2.7 has permission bits for 'others'
  >  > > +# set to 0.  Later during install, we copy Tools and Demo to the installed
  >  > > +# prefix, so set them right here.
  >  > > +    ${FIND} ${WRKSRC}/Tools ${WRKSRC}/Demo -type d | ${XARGS} ${CHMOD} a+rx
  >  > > +    ${FIND} ${WRKSRC}/Tools ${WRKSRC}/Demo -type f | ${XARGS} ${CHMOD} a+r
  >  > > +
  >  >  
  >  >  This can be reduced to one command
  >  >  
  >  >    ${FIND} ${WRKSRC}/Tools ${WRKSRC}/Demo \
  >  >                -type d -exec ${CHMOD} a+rx {} + \
  >  >            -or -type f -exec ${CHMOD} a+r  {} +
  > 
  > It's unclear to me why you have to use find(1) at all.
  > The following simple command should work equally well:
  > 
  >     ${CHMOD} -R og=u-w ${WRKSRC}/Tools ${WRKSRC}/Demo
 
 Yes, that's better still and will work fine since the user bits are
 good in the tarball.  Updated patch (with a fix for the path, too)...
 
 
 --9oaHwTfnCu
 Content-Type: text/plain; name="p"
 Content-Description: just use chmod; fix path with PYTHON_WRKSRC
 Content-Disposition: inline;
 	filename="p"
 Content-Transfer-Encoding: 7bit
 
 Index: Makefile
 ===================================================================
 RCS file: /base/FreeBSD-CVS/ports/lang/python27/Makefile,v
 retrieving revision 1.169
 diff -u -p -r1.169 Makefile
 --- Makefile	6 Sep 2010 00:25:04 -0000	1.169
 +++ Makefile	15 Nov 2010 18:16:55 -0000
 @@ -146,6 +146,12 @@ CONFIGURE_ARGS+=	--disable-ipv6
  CONFIGURE_ARGS+=	--with-fpectl
  .endif
  
 +post-extract:
 +# The distribution tarball for python 2.7 has permission bits for 'others'
 +# set to 0.  Later during install, we copy Tools and Demo to the installed
 +# prefix, so set them right here.
 +	${CHMOD} og=u-w ${PYTHON_WRKSRC}/Tools ${PYTHON_WRKSRC}/Demo
 +
  pre-patch:
  	${CP} -r ${PATCH_WRKSRC}/Lib/plat-freebsd8 \
  		${PATCH_WRKSRC}/Lib/plat-freebsd9
 @@ -260,12 +266,12 @@ post-install:
  .if !defined(NOPORTDATA)
  	@${MKDIR} ${DATADIR}
  	@cd ${PYTHON_WRKSRC}; ${TAR} -cf - Tools | \
 -		(cd ${DATADIR}; ${TAR} -xf -)
 +		(cd ${DATADIR}; ${TAR} --no-same-owner -xf -)
  .endif
  .if !defined(NOPORTEXAMPLES)
  	@${MKDIR} ${EXAMPLESDIR}
  	@cd ${PYTHON_WRKSRC}/Demo; ${TAR} -cf - * | \
 -		(cd ${EXAMPLESDIR}; ${TAR} -xf -)
 +		(cd ${EXAMPLESDIR}; ${TAR} --no-same-owner -xf -)
  .endif
  
  	@${CAT} ${PKGMESSAGE}
 
 --9oaHwTfnCu--