From owner-freebsd-bugs Wed May 6 03:07:30 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id DAA28467 for freebsd-bugs-outgoing; Wed, 6 May 1998 03:07:30 -0700 (PDT) (envelope-from owner-freebsd-bugs@FreeBSD.ORG) Received: from boco.fee.vutbr.cz (boco.fee.vutbr.cz [147.229.9.11]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id DAA28417; Wed, 6 May 1998 03:07:03 -0700 (PDT) (envelope-from xcejka00@dcse.fee.vutbr.cz) Received: from kazi.dcse.fee.vutbr.cz (kazi.dcse.fee.vutbr.cz [147.229.9.51]) by boco.fee.vutbr.cz (8.8.8/8.8.8) with ESMTP id MAA29768; Wed, 6 May 1998 12:03:13 +0200 (MET DST) Received: from sts.dcse.fee.vutbr.cz (sts.dcse.fee.vutbr.cz [147.229.9.52]) by kazi.dcse.fee.vutbr.cz (8.8.8/8.8.8) with ESMTP id MAA09225; Wed, 6 May 1998 12:03:12 +0200 (CEST) Received: (from xcejka00@localhost) by sts.dcse.fee.vutbr.cz (8.8.5/8.8.5) id KAA19547; Wed, 6 May 1998 10:03:12 GMT Message-Id: <199805061003.KAA19547@sts.dcse.fee.vutbr.cz> Subject: Re: bin/6521: Wait with commit please In-Reply-To: <199805051741.DAA28205@godzilla.zeta.org.au> from Bruce Evans at "May 6, 98 03:41:20 am" To: bde@zeta.org.au (Bruce Evans) Date: Wed, 6 May 1998 12:03:12 +0200 (MET DST) From: Cejka Rudolf Cc: freebsd-bugs@FreeBSD.ORG, phk@FreeBSD.ORG, xcejka00@dcse.fee.vutbr.cz X-Mailer: ELM [version 2.4ME+ PL31 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org > > Here is a small patch. But I don't think, it is the best solution: > > It is essentially identical with the buggy code that I removed in > rev.1.7 :-). It breaks `rmdir -p symlink/' where `symlink' is > a symlink to a directory and has some buffer underrun problems. > I think the symlink case can be handled properly by doing the > first rmdir before stripping and then checking if the supposedly > removed final path component is still there. The latter is just > to give a better error messsage (ENOTDIR for hitting a symlink > instead of ENOTEMPTY for attempting to remove a nonempty directory > containing a symlink). Note that `rmdir -p symlink/bar' does > not remove `symlink/', although `rmdir -p symlink/' does, since > there is nothing special about an intermediate slash. > > Bruce Now I'm looking, bin/6521 is suspended and waiting for commiters. Please wait, Bruce sent this mail to me. It is major - It needs some discussion at this time I think. Isn't best time to specify requirements for rmdir now and put them as comment in rmdir.c too (and fix rmdir)? -------------------------------------------------------------------------- Rudolf Cejka E-mail: xcejka00@dcse.fee.vutbr.cz Technical University of Brno, Faculty of El. Engineering and Comp. Science Bozetechova 2, 612 66 Brno, Czech Republic To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message