From owner-freebsd-x11@FreeBSD.ORG Thu Jan 29 19:53:37 2015 Return-Path: Delivered-To: x11@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 569AA21F for ; Thu, 29 Jan 2015 19:53:37 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 43285F89 for ; Thu, 29 Jan 2015 19:53:37 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t0TJrbIh041879 for ; Thu, 29 Jan 2015 19:53:37 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: x11@FreeBSD.org Subject: maintainer-feedback requested: [Bug 197184] x11/libxkbfile: fix build with clang 3.6.0 Date: Thu, 29 Jan 2015 19:53:37 +0000 X-Bugzilla-Type: request Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jan 2015 19:53:37 -0000 Dmitry Marakasov has reassigned Bugzilla Automation 's request for maintainer-feedback to x11@FreeBSD.org: Bug 197184: x11/libxkbfile: fix build with clang 3.6.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D197184 --- Description --- Created attachment 152348 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D152348&action= =3Dedit Patch I'm testing ports building on experimental projects/clang360-import branch,= and libxkbfile fails there because of more strict warnings of clang 3.6: --- =3D=3D=3D> Building for libxkbfile-1.0.8_2 /usr/bin/make all-recursive Making all in src CC cout.lo cout.c:48:46: error: address of array 'xkb->names->vmods' will always evalu= ate to 'true' [-Werror,-Wpointer-bool-conversion] if ((!xkb)||(!xkb->names)||(!xkb->names->vmods)) ~~~~~~~~~~~~~^~~~~ 1 error generated. *** Error code 1 --- The vmods member is really an array, so the warning is valid. The fix is to remove the useless check. It was already fixed upstream: http://cgit.freedesktop.org/xorg/lib/libxkbfile/commit/?id=3D9fa04388dcbb5b= f20531 9569f540a62c03754688 --- Comment #1 from Bugzilla Automation --- Auto-assigned to maintainer x11@FreeBSD.org=