From owner-svn-ports-head@freebsd.org Thu Mar 14 23:19:33 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E35B115333B4; Thu, 14 Mar 2019 23:19:32 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8A4F3732B6; Thu, 14 Mar 2019 23:19:32 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id 7559FC4E9; Thu, 14 Mar 2019 23:19:32 +0000 (UTC) From: Jan Beich To: Tobias Kortkamp Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r495583 - in head: mail/thunderbird/files www/cliqz/files www/firefox-esr/files www/firefox/files References: <201903131541.x2DFfHf4077221@repo.freebsd.org> <20190313155738.GA67271@urd.tobik.me> Date: Fri, 15 Mar 2019 00:19:27 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 8A4F3732B6 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.88 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_SHORT(-0.90)[-0.899,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]; NEURAL_HAM_MEDIUM(-0.99)[-0.989,0]; NEURAL_HAM_LONG(-1.00)[-0.998,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Mar 2019 23:19:33 -0000 Tobias Kortkamp writes: > On Wed, Mar 13, 2019 at 03:41:17PM +0000, Jan Beich wrote: > >> Author: jbeich >> Date: Wed Mar 13 15:41:17 2019 >> New Revision: 495583 >> URL: https://svnweb.freebsd.org/changeset/ports/495583 >> >> Log: >> www/firefox: unbreak on armv6/armv7/powerpc64 >> >> error: Could not compile `libc`. >> warning: build failed, waiting for other jobs to finish... >> error[E0433]: failed to resolve: use of undeclared type or module `mem` >> --> third_party/rust/libc/src/unix/bsd/freebsdlike/freebsd/powerpc64.rs:35:32 >> | >> 35 | pub const _ALIGNBYTES: usize = mem::size_of::<::c_long>() - 1; >> | ^^^ use of undeclared type or module `mem` >> >> Reported by: pkg-fallout >> >> Modified: >> head/mail/thunderbird/files/patch-bug1530098 (contents, props changed) >> head/www/cliqz/files/patch-bug1530098 (contents, props changed) >> head/www/firefox-esr/files/patch-bug1530098 (contents, props changed) >> head/www/firefox/files/patch-bug1530098 (contents, props changed) >> >> Modified: head/mail/thunderbird/files/patch-bug1530098 >> ============================================================================== >> --- head/mail/thunderbird/files/patch-bug1530098 Wed Mar 13 15:28:07 2019 (r495582) >> +++ head/mail/thunderbird/files/patch-bug1530098 Wed Mar 13 15:41:17 2019 (r495583) >> @@ -10,7 +10,7 @@ index 587d7582bc89..7cdb11ee2d6b 100644 >> @@ -1 +1 @@ >> [snip giant cargo-checksum.json diff] > > Do you think it might be possible to disable vendor checksums in > Gecko ports like lang/rust or graphics/librsvg2-rust do to not have > ~15000 column lines for .cargo-checksum.json in patches? Self-contained patches are easy to reason about, easy prune on update, easy to cherry-pick into other ports, easy to bisect in case of regressions by building outside of ports. Permanetly disabling vendor checksums only makes sense when patches are not inteded to be upstreamed e.g., when swapping out bundled libs with system dependencies. For one, in ~6.4 MiB large patch to restore --enable-rust-simd dropping .cargo-checksum.json would only shave ~9% of its size.