From owner-freebsd-usb@FreeBSD.ORG Sun Jan 27 18:49:48 2008 Return-Path: Delivered-To: freebsd-usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B035F16A41A; Sun, 27 Jan 2008 18:49:48 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 5B95C13C459; Sun, 27 Jan 2008 18:49:48 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.1/8.14.1) with ESMTP id m0RIlE0S099151; Sun, 27 Jan 2008 11:47:14 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sun, 27 Jan 2008 11:47:20 -0700 (MST) Message-Id: <20080127.114720.-1001128995.imp@bsdimp.com> To: henrik@gulbra.net From: "M. Warner Losh" In-Reply-To: <1201458988.2277.285.camel@Particle> References: <1201348494.2277.96.camel@Particle> <20080127032955.GI53741@server.vk2pj.dyndns.org> <1201458988.2277.285.camel@Particle> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-usb@freebsd.org, oliver@freebsd.org Subject: Re: usb/84336: [usb] [reboot] instant system reboot when unmounting a powered off/unplugged+replugged USB device X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jan 2008 18:49:48 -0000 In message: <1201458988.2277.285.camel@Particle> Henrik Gulbrandsen writes: : On Sat, 2008-01-26 at 20:40 -0700, M. Warner Losh wrote: : > One of the things that I've been working on with someone (whose name : > escapes me) and Bruce Evans is trying to address these issues. One : > problem we have today is that when the device return ENXIO, the buffer : > cache retries the operation rather than failing it upstream. There : > are a number of issues with doing this, including fixing all the : > filesystems to cope with errors. I've committed a number of 'keep the : > system from panicing' type fixes, but much works remains to be done. : : I'd like to think that I'm "someone" :-) Yes. Now that I see your name that's right. I couldn't find it in my email because I'm getting too old... : While I agree with you that there is still work to do, I think most of : it would actually be side issues not directly related to usb/46176 or : usb/84336. Things should be working for USB memory sticks and cameras, : but perhaps flash cards still trigger it, or file systems other than : msdosfs have problems, or the fix happens to introduce a memory leak. : All of these problems would be better handled with more specific PRs. : : Writing as the guy who actually spent two and a half hours in a futile : attempt to reproduce this problem with all patches applied, I'd say that : the usb/46176 problem has passed on. It is no more. It has ceased to be. : This is an ex-bug! At least until someone tells me why I'm a fool! :-) Yes. I've found things much more stable. With the currently committed subset of the patches applied, there's still a few crashes for me from time to time... Warner