Date: Mon, 29 Jul 2013 08:09:21 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Tim Kientzle <kientzle@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, Jason Helfman <jgh@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r323836 - in head/devel: . arm-eabi-binutils arm-eabi-binutils/files Message-ID: <20130729060918.GO98542@ithaqua.etoilebsd.net> In-Reply-To: <B6C67E6C-D548-4B6D-8A3E-AB55EA0CCB62@freebsd.org> References: <201307281645.r6SGjNAs020031@svn.freebsd.org> <CAMuy=%2BhFpUQRRkOgi0KEktqpFyNyX=6OTyP5rmSEsGqWo4A85w@mail.gmail.com> <B6C67E6C-D548-4B6D-8A3E-AB55EA0CCB62@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--HFD/Dq8JdnjNvyuv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 28, 2013 at 08:52:30PM -0700, Tim Kientzle wrote: >=20 > On Jul 28, 2013, at 12:09 PM, Jason Helfman wrote: >=20 > > On Sun, Jul 28, 2013 at 9:45 AM, Tim Kientzle <kientzle@freebsd.org> wr= ote: > > Author: kientzle (src committer) > > Date: Sun Jul 28 16:45:22 2013 > > New Revision: 323836 > > URL: http://svnweb.freebsd.org/changeset/ports/323836 > >=20 > > Log: > > Add arm-eabi-binutils cross-tools. > >=20 > > Approved by: db > >=20 > > Added: head/devel/arm-eabi-binutils/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/devel/arm-eabi-binutils/Makefile Sun Jul 28 16:45:22 201= 3 (r323836) > > @@ -0,0 +1,47 @@ > > +# $FreeBSD$ > > + > > +PORTNAME=3D binutils > > +PORTVERSION=3D 2.23.2 > > +CATEGORIES=3D devel > > +MASTER_SITES=3D ${MASTER_SITE_SOURCEWARE} > > +MASTER_SITE_SUBDIR=3D binutils/releases > > +PKGNAMEPREFIX=3D arm-eabi- > > + > > +MAINTAINER=3D kientzle@gmail.com > > +COMMENT=3D GNU binutils for vanilla ARM cross-development > > + > > +.if !defined(WITHOUT_NLS) > > +USE_GETTEXT=3D yes > > +PLIST_SUB+=3D NLS=3D"" > > +.else > > +CONFIGURE_ARGS+=3D --disable-nls > > +PLIST_SUB+=3D NLS=3D"@comment " > > +.endif > > +USE_BZIP2=3D yes > > +USE_GMAKE=3D yes > > +USES=3D gettext > > +GNU_CONFIGURE=3D yes > >=20 > >=20 > > Is there any particular reason that bsd.port.options.mk wasn't included= here? > >=20 > > USE_GETTEXT is deprecated, and should be using the USES framework to br= ing in the dependency. The only reason this dependency is working is that i= t is unconditionally brought in with the USES framework later in the Makefi= le. > >=20 > > To this affect, if NLS is disabled, it brings in gettext dependency. Ca= n it be disabled? > >=20 > > USE_GMAKE can be converted, as well, to the USES framework. (USES=3D gm= ake) > >=20 > > .include <bsd.port.options.mk> > >=20 > > .if ${PORT_OPTIONS:MNLS} > > USES+=3D gettext > > ... > > .endif=20 >=20 > Jason, >=20 > Please take a look at this updated version and let me know if > it addresses your concerns: >=20 > https://redports.org/browser/kientzle/devel/arm-eabi-binutils/Makefile >=20 >=20 Can be simplified: http://people.freebsd.org/~bapt/Makefile.txt In this version I use the options help to reduce complexity (yes the options helpers are not yet documented :() OPTIONS_SUB will convert anything in OPTIONS_DEFINE into the PLIST_SUB approriated. NLS_USES will add to USES its content only if NLS is on NLS_CONFIGURE_ENABLE will do the --enable/--disable configure args dancing. CFLAGS are automatically appended to CONFIGURE_ENV so just define properly = the macro is enough. regards, Bapt --HFD/Dq8JdnjNvyuv Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlH2Bw4ACgkQ8kTtMUmk6EzNwwCeI220U3x+hNx7S3Mgtlbp0Pgq OugAniSF/QG59cfc8pCFTjM+sklidjOE =+KWJ -----END PGP SIGNATURE----- --HFD/Dq8JdnjNvyuv--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130729060918.GO98542>