From owner-svn-src-all@FreeBSD.ORG Mon Sep 27 19:42:04 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F04D31065679; Mon, 27 Sep 2010 19:42:04 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id C3AB28FC1C; Mon, 27 Sep 2010 19:42:04 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 6A8F646B09; Mon, 27 Sep 2010 15:42:04 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 615B08A03C; Mon, 27 Sep 2010 15:42:03 -0400 (EDT) From: John Baldwin To: src-committers@freebsd.org Date: Mon, 27 Sep 2010 15:41:48 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; ) References: <201009271936.o8RJaG6J047624@svn.freebsd.org> In-Reply-To: <201009271936.o8RJaG6J047624@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201009271541.48624.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 27 Sep 2010 15:42:03 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r213226 - head/sys/i386/i386 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Sep 2010 19:42:05 -0000 On Monday, September 27, 2010 3:36:16 pm John Baldwin wrote: > Author: jhb > Date: Mon Sep 27 19:36:15 2010 > New Revision: 213226 > URL: http://svn.freebsd.org/changeset/base/213226 > > Log: > Rewrite the i386 memory probe: > - Check for SMAP data from the loader first. If it exists, don't bother > doing any VM86 calls at all. This will be more friendly for non-BIOS > boot environments such as EFI, etc. > - Move the base memory setup into a new basemem_setup() routine instead > of duplicating it. > - Simplify the XEN case by removing all of the VM86/SMAP parsing code rather > than just jumping over it. > - Adjust some comments to better explain the code flow. This could maybe be cleaned up a bit further by splitting getmemsize() up into two routines: one to populate physmap[], and one to do the rest. Then XEN could just have a separate routine for the first function for example. -- John Baldwin