From owner-cvs-src@FreeBSD.ORG Tue Apr 13 20:43:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 923E216A4CE; Tue, 13 Apr 2004 20:43:24 -0700 (PDT) Received: from kientzle.com (h-66-166-149-50.snvacaid.covad.net [66.166.149.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4C05843D55; Tue, 13 Apr 2004 20:43:22 -0700 (PDT) (envelope-from tim@kientzle.com) Received: from kientzle.com (p54.kientzle.com [66.166.149.54]) by kientzle.com (8.12.9/8.12.9) with ESMTP id i3E3hL90026239; Tue, 13 Apr 2004 20:43:22 -0700 (PDT) (envelope-from tim@kientzle.com) Message-ID: <407CB356.7060102@kientzle.com> Date: Tue, 13 Apr 2004 20:43:18 -0700 From: Tim Kientzle User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.4) Gecko/20031006 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Alfred Perlstein References: <200404140040.i3E0esil061104@repoman.freebsd.org> <20040414021526.GB63832@elvis.mu.org> In-Reply-To: <20040414021526.GB63832@elvis.mu.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: Tim Kientzle cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/tar bsdtar.c bsdtar.h write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Apr 2004 03:43:24 -0000 Huh? Maybe I'm missing something, but I don't see the instantiations to which you refer. I do see a lot of struct definitions, and a handful of function prototypes, but no variable declarations. If I messed up and did accidentally declare a variable, could you please point it out. I honestly can't see it. Tim Alfred Perlstein wrote: > While I applaud the effort here, it is a major violation of C > POLA to have compilable code within a header file. I think you > should basically move all the variables instantiated in bsdtar.h > to their appropriate .c files. > > thank you, > -Alfred > > * Tim Kientzle [040413 17:41] wrote: > >>kientzle 2004/04/13 17:40:54 PDT >> >> FreeBSD src repository >> >> Modified files: >> usr.bin/tar bsdtar.c bsdtar.h write.c >> Log: >> A simple cache of uid->uname lookups and gid->gname lookups eliminates >> almost 1/2 of the CPU time required to create an uncompressed archive >> and makes a noticable reduction in wallclock time. >> >> Revision Changes Path >> 1.6 +11 -0 src/usr.bin/tar/bsdtar.c >> 1.3 +14 -0 src/usr.bin/tar/bsdtar.h >> 1.7 +35 -12 src/usr.bin/tar/write.c > > >