From owner-freebsd-arch Wed Oct 9 13:55: 5 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0FC2C37B401; Wed, 9 Oct 2002 13:55:04 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id E34BD43E6A; Wed, 9 Oct 2002 13:55:02 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id GAA25112; Thu, 10 Oct 2002 06:55:00 +1000 Date: Thu, 10 Oct 2002 07:05:07 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: John Baldwin Cc: freebsd-arch@FreeBSD.ORG, Peter Wemm , Andrew Gallatin Subject: Re: lp64 vs lp32 printf In-Reply-To: Message-ID: <20021010064644.C6622-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 9 Oct 2002, John Baldwin wrote: > > ddb/db_examine.c: db_printf("%-*lz", width, (long)value); > > ddb/db_examine.c: db_printf("%8lz", (long)addr); > > > > Hmm, the second case doesn't even use a sign so it can be %x anyways. > And the first one doesn't use the '+' modifier either so it can just be > converted to use '%x' as well. Hmm, more likely is that probably > these two places should be using '+z' instead of just 'z'. So, > maybe 'y' instead of 'z'? '+' doesn't work normally in the kernel. It is a no-op before %d and it should be a similar no-op before %z (unless %+d is fixed or %z is renamed). However, it currently has the affect of unbreaking %z. s/z/y/ seems reasonable. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message