From owner-svn-src-all@freebsd.org Thu Jan 14 16:53:24 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F2F00A818B5 for ; Thu, 14 Jan 2016 16:53:24 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qg0-x233.google.com (mail-qg0-x233.google.com [IPv6:2607:f8b0:400d:c04::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A25581448 for ; Thu, 14 Jan 2016 16:53:24 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qg0-x233.google.com with SMTP id o11so487178947qge.2 for ; Thu, 14 Jan 2016 08:53:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=5vF2hpi/x5UqewDGVVb70JWvKuwlENolq6yPBppKAbY=; b=n4gfMv+5+t2Z2GveMj2F7QfEfXSaoBUkgTtAaTzXFU5zPy/EkZWZ7oimURIBiZukPj NxFD94qCrWWP9x0w1EBHFFnAK/zU1wYlC/DABgkKYb6c8256XB1vwGbB1y4i3PVaylB/ M5EcP1RV4xXRFdCBOs4/NmlOZTV0NevTqq+4hTRUZWTrXmqQ8Lb6PJxS0m7ZvrrnOJwG n9bgvMflG7LBrTGlyHvjtt2M2V8OoS+ppzyouaKUb3ypCcLUyCAnuNdsC2Ce+Guuau1u GG+C68r3dc42DVnuBENUYjIOTU++qr+q13DHjx1POl53mFB5EgwXMg7kEcjeMCtNnee8 O11g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=5vF2hpi/x5UqewDGVVb70JWvKuwlENolq6yPBppKAbY=; b=N1PMcz+mh27BRR6ijaSenVUmwbnisXu7xbOiDyD9fO+gOQkOomJSHAqBX7wWxo6Vfk 7WXPsi8x7x+Of5iLuUepcTzOAs+Rjs0f68awOJdpIEBue4KnUZD9vcu+RBQ4djTMEEj2 MhtWmk/tIJYG7kuTPjKPSqWJlP4zXQnitvpLdPvuO0BHX369Y/NAw0O2Q39j4rMxkfD4 ZNhAGRitTGh3UGhjKYP0FLWzW4qyRU64YnlYw2Cr/dO4zFOye8fGv+4ZT+9olg1MkIUt LA2OKiy3QtcRKZHJLLnS+CHhzTvO8MclLXpaVAWSHohCeTGlKBYPUGvXrn78Y+ALzy2u e6DQ== X-Gm-Message-State: ALoCoQm3ZpSQQbK0ynRQ7w7xDsh/imjNgG8blW2xyhb9h35NZ1IYCMQYi32kaFkqm1NVmb16BxIvbowkQ5waBofmZ/C+l9BiTw== MIME-Version: 1.0 X-Received: by 10.140.93.77 with SMTP id c71mr7250394qge.46.1452790403574; Thu, 14 Jan 2016 08:53:23 -0800 (PST) Sender: wlosh@bsdimp.com Received: by 10.140.30.166 with HTTP; Thu, 14 Jan 2016 08:53:23 -0800 (PST) X-Originating-IP: [69.53.245.12] In-Reply-To: <9A7534C4-0A2C-4DAC-981A-09868F1723DA@gmail.com> References: <201601140922.u0E9M1rV025146@repo.freebsd.org> <9A7534C4-0A2C-4DAC-981A-09868F1723DA@gmail.com> Date: Thu, 14 Jan 2016 09:53:23 -0700 X-Google-Sender-Auth: OlFx1-9vKEgQ-wvl1tXA3-PkxH4 Message-ID: Subject: Re: svn commit: r293903 - in head/sys/boot: arm/uboot efi/fdt efi/libefi From: Warner Losh To: NGie Cooper Cc: Steven Hartland , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2016 16:53:25 -0000 On Thu, Jan 14, 2016 at 2:47 AM, NGie Cooper wrote: > > > On Jan 14, 2016, at 01:27, NGie Cooper wrote: > > > > > >> On Jan 14, 2016, at 01:22, Steven Hartland wrote: > >> > >> Author: smh > >> Date: Thu Jan 14 09:22:01 2016 > >> New Revision: 293903 > >> URL: https://svnweb.freebsd.org/changeset/base/293903 > >> > >> Log: > >> Fix GCC warnings causing build failure after r293724 > >> > >> Disable some compiler warnings for GCC (non-standard compiler) fixing > >> build failures introduced by r293724, which enabled WARNS in the EFI > boot > >> code, when compiling with none standard compiler (GCC). > > > > Disabling warnings is wrong. Here=E2=80=99s how arm could be fixed: > > > > $ svn diff sys/boot/ > > Index: sys/boot/common/bootstrap.h > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- sys/boot/common/bootstrap.h (revision 293877) > > +++ sys/boot/common/bootstrap.h (working copy) > > @@ -32,6 +32,7 @@ > > #include > > #include > > #include > > +#include > > > > /* > > * Generic device specifier; architecture-dependant > > @@ -332,12 +333,8 @@ > > extern struct arch_switch archsw; > > > > /* This must be provided by the MD code, but should it be in the archsw= ? > */ > > -void delay(int delay); > > - > > void dev_cleanup(void); > > > > -time_t time(time_t *tloc); > > - > > #ifndef CTASSERT /* Allow lint to override */ > > #define CTASSERT(x) _CTASSERT(x, __LINE__) > > #define _CTASSERT(x, y) __CTASSERT(x, y) > > Index: sys/boot/efi/include/efiapi.h > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- sys/boot/efi/include/efiapi.h (revision 293877) > > +++ sys/boot/efi/include/efiapi.h (working copy) > > @@ -532,6 +532,7 @@ > > typedef > > EFI_STATUS > > (EFIAPI *EFI_RESERVED_SERVICE) ( > > + VOID > > ); > > > > typedef > > > > amd64 is a bit trickier: > > > > /scratch/tmp/ngie/svn/sys/boot/efi/libefi/../include/efigop.h:75: > warning: 'ms_abi' attribute directive ignored > > > > I didn=E2=80=99t dig into why this is happening [yet], other than there= maybe > being MS extensions involved? > > > > Thanks, > > -NGie > > This might fix amd64: > > Index: /scratch/tmp/ngie/svn/sys/boot/efi/libefi/../include/amd64/efibind= .h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- /scratch/tmp/ngie/svn/sys/boot/efi/libefi/../include/amd64/efibind.h > (revision 293877) > +++ /scratch/tmp/ngie/svn/sys/boot/efi/libefi/../include/amd64/efibind.h > (working copy) > @@ -160,8 +160,10 @@ > // > > #ifdef __amd64__ > +#if defined(__clang__) && (__clang_major__ >=3D 3 && __clang_minor__ >= =3D 5) > #define EFIAPI __attribute__((ms_abi)) > #endif > +#endif > > #ifndef EFIAPI // Forces EFI calling conventions > reguardless of compiler options > #ifdef _MSC_EXTENSIONS > Sure this fix is right? If you aren't marking the ABI correctly, how could this possibly work? Warner